Re: [PATCH v4 3/3] riscv: dts: spacemit: k3: Add UFS support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The platform driver is missing power management operations (.pm), which breaks system suspend/resume and runtime PM.
--

commit e432cf6faf83c7fe0612ce4cb8a3f5d0731598d9
Author: Yixun Lan <dlan@kernel.org>

scsi: ufs: spacemit: k3: Add UFS Host Controller driver

SpacemiT K3 SoC consist of UFS (Universal Flash Storage) Host Controller
which has features compatible with JEDEC UFS 2.2, MIPI UniPro v1.61 and
M-PHY v3.0 standard.

> diff --git a/drivers/ufs/host/ufs-spacemit.c b/drivers/ufs/host/ufs-spacemit.c
> new file mode 100644
> index 0000000000000..9d037d90ac5e3
> --- /dev/null
> +++ b/drivers/ufs/host/ufs-spacemit.c

[ ... ]

> +static struct platform_driver ufs_spacemit_pltform = {
> +	.probe	= ufs_spacemit_probe,
> +	.remove	= ufs_spacemit_remove,
> +	.driver	= {
> +		.name	= "ufshcd-spacemit",
> +		.of_match_table = of_match_ptr(ufs_spacemit_of_match),
> +	},
> +};

[Severity: High]
Does this platform driver need power management operations assigned to .pm?

Since .pm is missing in ufs_spacemit_pltform, the platform bus PM core won't
invoke any callbacks during system suspend/resume or runtime PM transitions.
This means the host controller and attached UFS device might not be placed
into a low-power state or have their hardware queues properly flushed during
suspend, and could resume in an inconsistent state causing hardware hangs or
data corruption if parent buses were powered down.

Could .pm be set here (for example, to a dev_pm_ops struct utilizing
ufshcd_system_suspend and ufshcd_runtime_suspend) to ensure the PM core
manages the UFS controller's power state?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-08-k3-ufs-support-v4-0-22aa2bd97d3b@kernel.org?part=3