Re: [PATCH v6 34/40] target: use 16-bits defined sense codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Unit Attention Interlock mode causes an infinite BUSY loop instead of a CHECK CONDITION because 'head' is not cleared.
--

commit cfc53d67bb91faecefbe9471ddf472fc26d50df4
Author: Damien Le Moal <dlemoal@kernel.org>

target: use 16-bits defined sense codes

This commit refactors the target core code to use 16-bit sense codes and
replaces hard-coded additional sense codes and qualifiers with defined enum
values. The stated goal is to improve code clarity with no functional changes
intended.

> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index dcfe945949167..ba208def8cb59 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
[ ... ]
> @@ -3566,21 +3567,19 @@ static void translate_sense_reason(struct se_cmd *cmd, sense_reason_t reason)
>  
>  	key = sd->key;
>  	if (reason == TCM_CHECK_CONDITION_UNIT_ATTENTION) {
> -		if (!core_scsi3_ua_for_check_condition(cmd, &key, &asc,
> -						       &ascq)) {
> +		if (!core_scsi3_ua_for_check_condition(cmd, &key, &code)) {
>  			cmd->scsi_status = SAM_STAT_BUSY;
>  			return;
>  		}

[Severity: High]
This is a pre-existing issue, but does this error handling correctly match
what is returned by core_scsi3_ua_for_check_condition() when Unit Attention
Interlock mode is enabled?

[ ... ]
> diff --git a/drivers/target/target_core_ua.c b/drivers/target/target_core_ua.c
> index 4276690fb6cbd..ea97b05d47ab7 100644
> --- a/drivers/target/target_core_ua.c
> +++ b/drivers/target/target_core_ua.c
[ ... ]
> @@ -232,8 +230,7 @@ bool core_scsi3_ua_for_check_condition(struct se_cmd *cmd, u8 *key, u8 *asc,
>  		 * clearing it.
>  		 */
>  		if (!dev_ua_intlck_clear) {
> -			*asc = ua->ua_asc;
> -			*ascq = ua->ua_ascq;
> +			*code = scsi_sense_code(ua->ua_asc, ua->ua_ascq);
>  			break;
>  		}

[Severity: High]
This is a pre-existing issue, but because this branch in 
core_scsi3_ua_for_check_condition() breaks out of the loop without resetting
"head" to 0, the function ends up returning false below since head remains 1:

	return head == 0;

Since translate_sense_reason() interprets the false return as a failure, it
responds with SAM_STAT_BUSY. Does this leave the LUN completely wedged by
returning SAM_STAT_BUSY infinitely to all commands whenever Unit Attention
Interlock mode is enabled, preventing the initiator from ever clearing the
condition?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908090308.1085097-1-dlemoal@kernel.org?part=34