From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D93D513570; Tue, 8 Sep 2026 10:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788863606; cv=none; b=rOMJllzsz0XiVVc6OY1SMziDAn0DcBzLHpfX6+ZGEBKCRWA230uWxPENfZu1qdWxkiniTOsGHRKixmIln5S8X+rkFc2/5vJebw1av9OBnILMJuS9uo9VPj3WU3Y8VjJIVGySbSsXDMAN9xBftZ7xfAm/VEq5CJbe2TQzdY0KCB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788863606; c=relaxed/simple; bh=YfvmasnhZqaGc0XmNApt5mr0MT4NMorPtTobQDK5N7s=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=fwM43mZnTtcaIwHCCrwHn1phvshMohI/WCnDNpSwUWnV/iA3EbECx8YxdIKSzDLU374+nAztxrQZKnLcycBus1E6tw6Ud6RTkMhJQzGn6XMbw2uQVsp3ueXbDjZlIsvhwoEr30IolsfseK0MKCcZ92lwdrMFzwQvtZ5I8UK4mCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JXTxrusv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JXTxrusv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1AD391F00A3A; Tue, 8 Sep 2026 10:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788863604; bh=YfvmasnhZqaGc0XmNApt5mr0MT4NMorPtTobQDK5N7s=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=JXTxrusvvcipD1rWWK9vISUA7hwxpZ4iP10ivfrgBrp3Wx/ccSQbkk9mjdKbOy5MD 4L3QTUCTeLGNHwEP8mboTc5AdEtkStGOjpMyEQCssiDseDNJnXolEc0CIUtyxQ8S0Z V5FKV2stxHBsvgMBGq1rdzrPx94cRfwZFXW2MqVP0Wmk0H1ZeoGVNjp4SOR0wfD3XC MkzHX/ee61L6mx2dkVaDqq7hCB6KBwJ9UczGzNE8PtLNw6EIFy8PbfY0w7PNo9ZtbG KjbQM9GhZnMBRtToENF63uxrzbDiEOu1c88/ogpmUx7TOb2YcishP2fnPMFT48eagN 2wvaGNsZrrIVQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 37/40] ata: libata: use 16-bits defined sense codes Reply-To: sashiko-reviews@lists.linux.dev To: "Damien Le Moal" Cc: linux-ide@vger.kernel.org, "Vasily Gorbik" , "Alexander Gordeev" , cassel@kernel.org, linux-s390@vger.kernel.org, "Christian Borntraeger" , linux-scsi@vger.kernel.org, dlemoal@kernel.org, "Heiko Carstens" In-Reply-To: <20260908090308.1085097-38-dlemoal@kernel.org> References: <20260908090308.1085097-1-dlemoal@kernel.org> <20260908090308.1085097-38-dlemoal@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 10:33:23 +0000 Message-Id: <20260908103324.1AD391F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > Refactor libata core code to use the 16-bits sense_code field of > struct scsi_sense_hdr and replace all hard-coded additional sense codes > and additional sense code qualifiers with the enum values defined in > include/scsi/scsi_sense.h. This helps with code clarity as the sense codes > being processed are easier to test and self-documented. >=20 > No functional change intended. >=20 > Signed-off-by: Damien Le Moal Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260908090308.1085= 097-1-dlemoal@kernel.org?part=3D37