Re: [PATCH v9 9/9] scsi: ibmvfc: handle extended FPIN events

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but the target lookup logic in `ibmvfc_find_target` contains a logical error that unconditionally skips every valid target, causing it to always return NULL and completely breaking FPIN asynchronous event processing.
--

commit 9ac7aa2b8bc80c6159248d07f474070225aca779
Author: Dave Marquardt <davemarq@linux.ibm.com>

scsi: ibmvfc: handle extended FPIN events

Implement support for extended FPIN messages received via the
asynchronous sub-queue, completing full FPIN functionality.

> diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> index 6eb299989724d..bd10c3fd5ccf5 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c

[ ... ]

> @@ -3511,6 +3547,7 @@ static struct ibmvfc_target *ibmvfc_find_target(struct list_head *target_list,
>  static void ibmvfc_process_async_work(struct work_struct *work)
>  {
>  	struct ibmvfc_async_sub_crq *subq = NULL;
> +	struct ibmvfc_async_subq_fpin *sqfpin;
>  	struct ibmvfc_async_work *aw;

[Severity: High]
This isn't a bug introduced by this patch, but the target lookup logic in
ibmvfc_find_target() in drivers/scsi/ibmvscsi/ibmvfc-core.c contains a
logical error that unconditionally skips every valid target, completely
breaking FPIN asynchronous event processing.

When an FPIN is received, ibmvfc_handle_async() queues
ibmvfc_process_async_work(), which calls ibmvfc_find_target(). Inside
ibmvfc_find_target(), there is this check:

	if (!tgt->rport || !tgt->nvme_remote_port)
		continue;

Since the lists of SCSI and NVMe targets are strictly separated, a target
will only have either rport or nvme_remote_port populated, but never both.
This causes the condition to always evaluate to true, skipping all valid
targets and unconditionally returning NULL.

Since all FPIN events from the fabric will be dropped due to the failed
target lookup, does this make the extended FPIN functionality added by
this patch completely unreachable in practice?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-ibmvfc-fpin-support-v8-0-b27183b055af@linux.ibm.com?part=9