From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64A7443E4D; Fri, 11 Sep 2026 07:08:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789110544; cv=none; b=sW5B9n2KbYDoS/zAyR+9JP/DVmfsTUGJsB9B8WRdgekeSEZp3FodjKGoVMER45QIYgiYmOvLJgZUNIHddsUGhZYDm/oN4VnLUWMlWEJ2MLIkVzK8CBtMtao7GlleVhEo3WkwmiPuhYVBIYiLBn5g7UBDpI7EHQNaZjSekl6rcu8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789110544; c=relaxed/simple; bh=qLgl/y6uwmWiSYiLOJQv+2Qf95OuyS9e1jpTxRnjip4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=arNmI+wP3EVLNHFDyWSruEUgL2PhWtT1kqTQw5kMOgqT+GwvaTOK3Nx7dYB171sX0ojd6HpgLkNpoZuzxeFCQDgnYtgn+Yj7hVNC3eZfhKVYhX6uDCUMDo2lhmLqzX7S99+i0p6ctAmSeOnOHCRs7DwF8gNMpqMq6Gl2W+geDmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=lst.de; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=1UgFm9Uf; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="1UgFm9Uf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=ba7IrE+O9fLqx7O4sbIbWky8QPaButuM0hAWYiFVjPE=; b=1UgFm9UfsZXhAycEbPpmA9ryHu og3w5/VhHCld7lvhO0WXLvwODXQVf+2gmVgWmqixaC+XMTItqaH6dKOkdTCThovPunE8OfAH/Bd7Z nbGWvM/pAJL7O8vafWezIRyuyL826Un9k7+oUENwZC13IeD8Oy/dneLz3K4RtsXpM2yK7CFZhk6Xy 9DGF9hbl/IGBF6wf+NO0AZJ3P46b/dKVO9LV4RkgxYSyPlR/GFjpwbYuq+wjfes6r5z4ufgNRkFMW fwn/uYNS3q6PYUnUGXxaChAW8dKQek2M1ngPXSxmbfooDF9wdMhrVa1Jl2f1XGxw0yQv/GdOH7zgi oyk+sO0A==; Received: from 2a02-8389-2301-9f00-b711-947d-6c5b-1af5.cable.dynamic.v6.surfer.at ([2a02:8389:2301:9f00:b711:947d:6c5b:1af5] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4vNU-0000000G08w-2yRz; Fri, 11 Sep 2026 07:08:53 +0000 From: Christoph Hellwig To: Zorro Lang Cc: fstests@vger.kernel.org, "Martin K. Petersen" , Kanchan Joshi , Anuj Gupta , John Garry , "Darrick J. Wong" , linux-scsi@vger.kernel.org Subject: [PATCH 5/6] generic: test I/O on devices with T10 protection information Date: Fri, 11 Sep 2026 09:08:23 +0200 Message-ID: <20260911070831.1760646-6-hch@lst.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260911070831.1760646-1-hch@lst.de> References: <20260911070831.1760646-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Add a test that runs fsx in buffered and direct I/O mode on T10 PI type 1, 2, 3 with and without strip/insert using scsi_debug. Signed-off-by: Christoph Hellwig Reviewed-by: Kanchan Joshi Reviewed-by: "Darrick J. Wong" --- tests/generic/2301 | 97 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/2301.out | 73 +++++++++++++++++++++++++++++++ 2 files changed, 170 insertions(+) create mode 100755 tests/generic/2301 create mode 100644 tests/generic/2301.out diff --git a/tests/generic/2301 b/tests/generic/2301 new file mode 100755 index 000000000000..35d1fb4574e8 --- /dev/null +++ b/tests/generic/2301 @@ -0,0 +1,97 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2026 Christoph Hellwig +# +# FS QA Test No. 2301 +# +# Basic FSX sanity check when using T10 protection information +# +. ./common/preamble +_begin_fstest auto rw pi dangerous + +_cleanup() +{ + cd / + rm -r -f $tmp.* + [ -d "$SCSI_DEBUG_MNT" ] && _unmount $SCSI_DEBUG_MNT 2>/dev/null + _put_scsi_debug_dev +} + +. ./common/scsi_debug + +_require_debugfs +_require_scsi_debug +# If TEST_DEV is block device, make sure current fs is a localfs which can be +# written on scsi_debug device +_require_test +_require_block_device $TEST_DEV +_require_odirect + +_fixed_by_kernel_commit 8a8685b32c07 \ + "iomap: don't free integrity payload that doesn't exist" + +size=$(_small_fs_size_mb 256) + +# like run_fsx(), but using a custom path +fsx_run() +{ + _run_fsx_on_file $SCSI_DEBUG_MNT/junk $@ || _exit 1 +} + +test_dif() +{ + local pi_type=$1 + local pi_enable="$2" + + scsi_debug_pi_opts="write_same_length=0 dif=${pi_type} dix=1" + SCSI_DEBUG_DEV=`_get_scsi_debug_dev 512 512 0 $size $scsi_debug_pi_opts` + + local integrity_path="$(_sysfs_block_integrity_path $SCSI_DEBUG_DEV)" + if [ ! -d "$integrity_path" ]; then + _notrun "DIF not supported by running kernel" + fi + + SCSI_DEBUG_MNT="$TEST_DIR/scsi_debug_$seq" + rm -rf $SCSI_DEBUG_MNT + mkdir $SCSI_DEBUG_MNT + + _mkfs_dev $SCSI_DEBUG_DEV || \ + _fail "Can't make $FSTYP on DIF-enabled scsi_debug device" + run_check _mount $SCSI_DEBUG_DEV $SCSI_DEBUG_MNT + + echo $pi_enable > $integrity_path/read_verify + echo $pi_enable > $integrity_path/write_generate + + # fsx load similar to generic/091 + echo "Testing direct I/O for DIF type $pi_type (enabled: $pi_enable)" + bsize=$($here/src/min_dio_alignment $SCSI_DEBUG_MNT $SCSI_DEBUG_DEV) + fsx_run -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W + fsx_run -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W + fsx_run -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W + fsx_run -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W + fsx_run -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W + fsx_run -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W + + # fsx load similar to generic/091 but using buffered I/O + echo "Testing buffered I/O for DIF type $pi_type (enabled: $pi_enable)" + fsx_run -N 10000 -l 500000 + fsx_run -N 10000 -o 8192 -l 500000 + fsx_run -N 10000 -o 32768 -l 500000 + fsx_run -N 10000 -o 128000 -l 500000 + + [ -d "$SCSI_DEBUG_MNT" ] && _unmount $SCSI_DEBUG_MNT 2>/dev/null + _put_scsi_debug_dev +} + +# Test with PI fully enabled +test_dif 1 1 +test_dif 2 1 +test_dif 3 1 + +# Test with strip / insert in the HBA +test_dif 1 0 +test_dif 2 0 +test_dif 3 0 + +# success, all done +_exit 0 diff --git a/tests/generic/2301.out b/tests/generic/2301.out new file mode 100644 index 000000000000..dda88676a219 --- /dev/null +++ b/tests/generic/2301.out @@ -0,0 +1,73 @@ +QA output created by 2301 +Testing direct I/O for DIF type 1 (enabled: 1) +fsx -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W +Testing buffered I/O for DIF type 1 (enabled: 1) +fsx -N 10000 -l 500000 +fsx -N 10000 -o 8192 -l 500000 +fsx -N 10000 -o 32768 -l 500000 +fsx -N 10000 -o 128000 -l 500000 +Testing direct I/O for DIF type 2 (enabled: 1) +fsx -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W +Testing buffered I/O for DIF type 2 (enabled: 1) +fsx -N 10000 -l 500000 +fsx -N 10000 -o 8192 -l 500000 +fsx -N 10000 -o 32768 -l 500000 +fsx -N 10000 -o 128000 -l 500000 +Testing direct I/O for DIF type 3 (enabled: 1) +fsx -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W +Testing buffered I/O for DIF type 3 (enabled: 1) +fsx -N 10000 -l 500000 +fsx -N 10000 -o 8192 -l 500000 +fsx -N 10000 -o 32768 -l 500000 +fsx -N 10000 -o 128000 -l 500000 +Testing direct I/O for DIF type 1 (enabled: 0) +fsx -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W +Testing buffered I/O for DIF type 1 (enabled: 0) +fsx -N 10000 -l 500000 +fsx -N 10000 -o 8192 -l 500000 +fsx -N 10000 -o 32768 -l 500000 +fsx -N 10000 -o 128000 -l 500000 +Testing direct I/O for DIF type 2 (enabled: 0) +fsx -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W +Testing buffered I/O for DIF type 2 (enabled: 0) +fsx -N 10000 -l 500000 +fsx -N 10000 -o 8192 -l 500000 +fsx -N 10000 -o 32768 -l 500000 +fsx -N 10000 -o 128000 -l 500000 +Testing direct I/O for DIF type 3 (enabled: 0) +fsx -N 10000 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 8192 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 32768 -l 500000 -r BSIZE -w BSIZE -Z -R -W +fsx -N 10000 -o 128000 -l 500000 -r BSIZE -w BSIZE -Z -W +Testing buffered I/O for DIF type 3 (enabled: 0) +fsx -N 10000 -l 500000 +fsx -N 10000 -o 8192 -l 500000 +fsx -N 10000 -o 32768 -l 500000 +fsx -N 10000 -o 128000 -l 500000 -- 2.53.0