From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5025208D4; Thu, 17 Sep 2026 17:45:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789667126; cv=none; b=CbQpOi1K/16S4VUvIhRkRHTMKwfKoz+/viv9/rEobgSK4ZJzOlYiNjmjnUGuLJMXf7Yh5XVs0UdS4J41vfmCgLOraeItdhuACGbCGyXt86M0OJ3/ikP9g2f9YPSQle6U1ycgXB/zs+9Ag18kkpwPdnklmeP0trC2hX6BT17oy7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789667126; c=relaxed/simple; bh=O5H1hZshSBJhIdHc0JA75duWW0fV+utc0ymv/zcPeG4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Ck1BHeKWwD2Cip/bx0doOcuHK+Kw8+Za24eDkUnGMUsPKXJd4okzoIm/Ny+jvwENMEc/q9sC65Hfq3DFbGtDVyRU5jWsuFid+gtbMNzbSjee5ilaWfbXFm1MCdBeDm0G074+Pytf8j+b62iETC3SVU6thORhaskdMNx503e8luI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FDxiI0WY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FDxiI0WY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 320DF1F00898; Thu, 17 Sep 2026 17:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789667125; bh=O5H1hZshSBJhIdHc0JA75duWW0fV+utc0ymv/zcPeG4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=FDxiI0WYmPE+oVgUqhtaheFOAWoC1aqIFOC2otsBZmnP/i9esxnpXeU9vwojN6bTO Qha23w5ktUfKIX7sLWtEN01QMYTSdhScryve/O5xXGgoNDgc8PSArdNBaGp6Cux1OX uMxsbCetIg4fqFjXqBUzFFChH8stVNOQqrQE68cKAEAFS7Qkoh5MmNQ3FehqtoanSa lGJKNeHXBPASZ4VtHRu71cHXxpPUPJOmUNoNDXI/ye9PqTf+JS+z05lEOfyMDs1dJs tasrjzN4CkUzwhCxybqUD8eTXVENeS38ol4pqdEbSPTCy7doGx5k2YpFZkBbVC3umv +PnUcy8bkc1Aw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 34/40] mm: eliminate VMA_SPECIAL_FLAGS usage when hugetlb explicitly tested Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org, "Christian Borntraeger" , "Heiko Carstens" , "Marc Zyngier" , selinux@vger.kernel.org, dri-devel@lists.freedesktop.org, "Vasily Gorbik" , kvmarm@lists.linux.dev, linux-scsi@vger.kernel.org, "Oliver Upton" , bpf@vger.kernel.org, kvm@vger.kernel.org, "Alexander Gordeev" , linux-perf-users@vger.kernel.org In-Reply-To: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-34-4583d8a23bca@kernel.org> References: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org> <20260917-b4-mmap-prepare-vma-flag-sanify-v3-34-4583d8a23bca@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Sep 2026 17:45:23 +0000 Message-Id: <20260917174524.320DF1F00898@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > It is now an invariant that VMA_IO_BIT is not set except by kernel-owned > mappings, so each existing VMA_SPECIAL_FLAGS test need only test for > VMA_DONTEXPAND_BIT, VMA_PFNMAP_BIT and VMA_MIXEDMAP_BIT. >=20 > This is precisely a test for a kernel-owned or fixed mapping. >=20 > Update a number of callsites which already explicitly handle hugetlb > mappings. >=20 > vma_supports_mlock() and ksm_compatible() also explicitly bail on droppab= le > mappings - detecting kernel-owned, fixed or droppable mappings is handled > by vma_is_persistent(), so in these cases use this predicate. >=20 > should_skip_vma() tests for locked, kernel-owned or fixed memory (having > already excluded hugetlb mappings) so simply test for those there. >=20 > No functional change intended. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260917-b4-mmap-pr= epare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org?part=3D34