From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B2F34D7D48 for ; Thu, 17 Sep 2026 11:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789645765; cv=none; b=ZG3SsLsPBXeTQys0YsfDvdaQdVVRN7gMDFYd4V8nSAeCVoAN+qvQoHa2xjoyeKXK+BipTcBhOBQF7dOOZMyNyjckVwBtrH0H8NUP4hNHqNBChIPZnmlPUU7aWwITTTm/9k+rjrvuiJ9WcY3ZJJYnfurh0N+RdyeETMfhH9Edb+c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789645765; c=relaxed/simple; bh=x+mSIjNwwPWCAJ+fSw8AqoOhMOv22uDk+npErG+nkUo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=LbLxn5u2Zb9UvOuRPFbsrOOf/auX9xG0zqnobknEGT/hlAv6f2AydNR2sOwT9mdLNqWDqYKDhSP93GMsos+1Z5U6EURSBDIhtVjCWkNBugDpHfUOeaWtWG4NPT8TK3/N/afmPmpXYhYMuXUv0Mt1vfBPd7w6p449w5T4jcC4qbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G9T1fHeq; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G9T1fHeq" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccb652d7so625274a91.0 for ; Thu, 17 Sep 2026 04:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789645762; x=1790250562; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=x+mSIjNwwPWCAJ+fSw8AqoOhMOv22uDk+npErG+nkUo=; b=G9T1fHeqBOUEsUwv3l1dPHfBiO8S8BBCxTVbu/ubqglD6ictKxG3kur9h/fUMNvHX5 NLfZtOJkwWauOPOIGZmpEpZ0xUT4LKyAqRHAzz6+FFsbdeBu3+wDGdUPAkTBQBCV9yOH pWkVhffMFPjSRwt7zFX8J+0ZfdYqUAkiPN+P6LB5VxZD/NJ53AvVthbK0CKwsa7xMQOy ED+RIKsJ7BGfcJf+uiHLBnEWODtFmuwVX6/t+KIjNr0p3JiTbViFNotX1TsvQz0eO9Gz KSA8rEYn6gEaYCjyzViEcU7ba8sJIxfoa0pBVW5f+42qmLUWvmUYzydwllBdK+oEzJfq GvBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789645762; x=1790250562; h=references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x+mSIjNwwPWCAJ+fSw8AqoOhMOv22uDk+npErG+nkUo=; b=Nkh/zg18DS2pdP34CqxNZ5rl6m7rOzxV8fMuFOq1XRx5zi3aOiVRtxZgIczaS5ud8h Ozkgpk0yOuArIt27AnFlSlZDyybdOM8rjcDStf7uzxZGu85+FYgpf+S5u7lQXAibEuyW inkwBlecee8WxTSZF5/c6C9QfotbTw5a3p1xaBrA/4GfPZkWk8+LsOh54TRgT7GDVmRr HeQGxjA12HDul+MDcMgsPtj+dqZQ/T9jueJbLe8j1lTtOpH+hUoeOIKpceViAbaLlsKo cQWgyTEuEN4eskB1EJ2whOVgtxkUm7pD3wRDEMgRMCad+2ckRL08uCb894BFonMDdYJu crsw== X-Forwarded-Encrypted: i=1; AKwUvBzghwUi44USDFWYZzkkO7ZW8NjRZ6VKrQLcwi0CMd0zsTyKrcEQxWCqIGpEnw1ipPr9JJ64OvhqKcXr@vger.kernel.org X-Gm-Message-State: AFuF++kbCPW0E/eg+9VI8DynifsJs2pbQaKrTPeW0vNaDjYlh8c5jxEL ggpvLY3V7IoppboHDQzXoNI2k4ossZjGF6YK6qjnDKp/IRBCoJA4+KO+6eSdMDrWMYo= X-Gm-Gg: AYBFou1EM3Q6MxFONiN5DNLzU6q7hv6Sr88abEF792eZh/ZmCmO+3Vq1aQoap9qULim J4hDkZMu3omrPlIOaKsid5dtqlZypeXVq+Y/D80eqVc2Eq7a+uLq5frJkxWe2/aISzxF1SrKNM6 EujklrxgBtFaWz+1oCFGLnY1oJ6RtvwsseFFCJzU7vHbPYyXPqdVn9qxEIMR/TGbNv3Wa62DWZb QCtudG/c51avfYPkL1MreWr5ScWg+GAMun+SPhzQw6NZc/ddilyB+wa6CSbg+EfgLWsvMn4IjaH ipQ4JQNfX2VL/PToy1oysxPl4cwCGHhYIxI6Qxy8GZDHEKE4vTEQmiup8avOFkiIotsIfDlnocK wMwLeJEr/2lA6PhzbglDk0IAxvXKy0jUbZ9Eq3kVu7+ew9dHpVn81MPaSDgxKP0xQwSR7i1aCJt We4g7KDsZFdhs00Sp6/gzRwPLZPop8tDgPKF7SJhjYgNyz7O080QVehFLgtVsH3g2gEPv5Yg== X-Received: by 2002:a17:90b:2249:b0:398:c3c9:d0ae with SMTP id 98e67ed59e1d1-39e1df7d64bmr13875098a91.0.1789645762177; Thu, 17 Sep 2026 04:49:22 -0700 (PDT) Received: from [127.0.1.1] ([240e:b8f:977f:f400:ec2a:b15e:fef8:70a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e39b0399bsm1178502a91.2.2026.09.17.04.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2026 04:49:21 -0700 (PDT) From: Liang Haowen To: Lee Jones Cc: linux-leds@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, sashiko-reviews@lists.linux.dev Subject: Re: [PATCH RFC v6 1/1] leds: asus-aura-scsi: Add ASUS Aura RGB LED driver for ROG NVMe enclosures Date: Thu, 17 Sep 2026 11:49:18 -0000 Message-Id: <202609172115.ReplyLeeR6.lhw@gmail.com> In-Reply-To: <20260917112840.GJ1605367@google.com> References: <202609012200.RFC0.lhw@gmail.com> <202609012200.RFC1.lhw@gmail.com> <20260901145204.2BF551F000E9@smtp.kernel.org> <202609032000.RFCv2-0.lhw@gmail.com> <202609032000.RFCv2-1.lhw@gmail.com> <20260903122408.3CA6B1F00A3A@smtp.kernel.org> <20260903161357.GX2133376@google.com> <202609042000.RFCv3-0.lhw@gmail.com> <202609042030.RFCv3-1.lhw@gmail.com> <20260904131503.355C41F00A3E@smtp.kernel.org> <20260910093232.GO2133376@google.com> <202609152112.RFCv4-0.lhw@gmail.com> <202609152112.RFCv4-1.lhw@gmail.com> <20260915130050.E8CDB1F000FF@smtp.kernel.org> <20260916104305.GM11487@google.com> <202609162015.RFCv5-0.lhw@gmail.com> <202609162015.RFCv5-1.lhw@gmail.com> <20260916122740.921E51F000FF@smtp.kernel.org> <20260916130602.GS11487@google.com> <202609162200.RFCv6-0.lhw@gmail.com> <202609162200.RFCv6-1.lhw@gmail.com> <20260916143832.520721F000FF@smtp.kernel.org> <20260917112840.GJ1605367@google.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: This one is the same false positive as in every round so far: kzalloc_obj() has been in include/linux/slab.h since v7.0 (line 1152 in the 7.2.4 tree this driver builds against), so the bot's reference tree simply predates it. Nothing to fix. I considered switching to plain kzalloc() to end the loop, but checkpatch on 7.2.4 flags that form with "Prefer kzalloc_obj over kzalloc with sizeof", so the two tools disagree and I would rather keep the checkpatch-clean one. Happy to switch if you prefer kzalloc(). Both questions from the v6 cover letter are still open, by the way: whether deferring the Kconfig/Makefile/MAINTAINERS wiring to the agreed SCSI transport split is acceptable for an RFC, and whether "led" should become a LED_FUNCTION_* value or the plain ordinal function is fine.