Re: [PATCH] scsi: fix additional sense code definition

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] scsi: incomplete macro rename leaves #undef ASC, breaking sparc builds
--

commit c2cd70c047b8b139d3b1ed0fd15c700a718e24ce
Author: Damien Le Moal <dlemoal@kernel.org>

scsi: fix additional sense code definition

This patch renames the ASC() and ASC_DEF() macros to SCSI_ASC() and
SCSI_ASC_DEF() to resolve a naming conflict with sparc architecture
headers.

Closes: https://lore.kernel.org/oe-kbuild-all/202609180743.kyprDg18-lkp@intel.com/

> diff --git a/include/scsi/scsi_sense.h b/include/scsi/scsi_sense.h
> index a210a93c1e4e8..f213c52776968 100644
> --- a/include/scsi/scsi_sense.h
> +++ b/include/scsi/scsi_sense.h
> @@ -30,10 +30,10 @@ enum scsi_sense_key {
>  	COMPLETED		= 0x0f,
>  };
>  
> -#define ASC_DEF(name)	ASC_##name
> -#define ASC(name, code)					\
> -	ASC_DEF(name)	= (code),			\
> -	name		= ((code) << 8) | 0x00
> +#define SCSI_ASC_DEF(name)	ASC_##name
> +#define SCSI_ASC(name, code)				\
> +	SCSI_ASC_DEF(name)	= (code),		\
> +	name			= ((code) << 8) | 0x00

[Severity: Low]
Were the corresponding #undef directives at the end of this file missed
during the rename?

Further down in include/scsi/scsi_sense.h, these remain:

#undef ASC_DEF
#undef ASC

This leaves the newly renamed SCSI_ASC and SCSI_ASC_DEF macros leaking
into the global namespace, and unintentionally undefines the external ASC
macro. This seems like it will result in an undeclared identifier
compilation error on sparc builds that include both headers in the same
translation unit.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918061102.2224753-1-dlemoal@kernel.org?part=1