From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f43.google.com (mail-pj2-f43.google.com [74.125.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D70437C10C for ; Sat, 19 Sep 2026 20:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789850897; cv=none; b=BNIYAobYtvP8LVpT96f8GBo6O/sACsY2ZwYzQRVPPQm7Plfz2Cz4ils5L6HkD8BckWJQssgje2d2oW4NFQCSO1e9vUA6aHRq/KFi0dbtxQWDrVlhYq2aUVciV77iIbxHxOHQeGoIsVTYbqCNudw4nMbkDtAua7C/Dz+NnHc9Sww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789850897; c=relaxed/simple; bh=Wb09/JqlWJCK0aAKjwbDIwW16IbDVzkKuvcsiDzrVaA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kQoax1xBiAkJt9kE1iWoo0PwE4IE7gik5yGcLUw3htMCiL7jfOUzj4GeXbGZLCfPWGxlCZWiBt9fR6VSqWE/6dBbUKLUdHekKrdqNs/1KRw1oEuOFiNyi2JAz+VVWilSpyneL5VVtSOGGRIc4HPjmEOSnIH1V08OKrgvXYMvHdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MsNnZKnb; arc=none smtp.client-ip=74.125.227.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MsNnZKnb" Received: by mail-pj2-f43.google.com with SMTP id 98e67ed59e1d1-396ccc02279so1472877a91.1 for ; Sat, 19 Sep 2026 13:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789850896; x=1790455696; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YHVLNPODpQem+e5CBn4rhBgJZPtKTuV2DsJXEMmdlks=; b=MsNnZKnbYtalo6VLRyRHf3QUCt+035GNQIieseHs9wA0n8C5Sz33THd204rMzJB07K e47GgVVxch6QiVm/6m9N6dB+SN5PXB7Um0UkDc32VhjFSlpZFaeVoPXdBlUnIn9zS1ni /IkM/OxgD+6Fv4Z+BoL2D2xC+0E8vwtOnEp2pK1AhmlxfwU+OMllKfHSDsZ2pwTLr+3u OUYXMEdcyM9Z7/7wdrLrQko2uB4niWC88Fe4kbe3/kqneaoEaNdMegcI557YeACUCtnE O1l/wDvjuY3+UWntSEZpfQI4wHigWAsBHX4vZNKvOSpmHzNnDj53wfvoaSSxODyKS5E1 5GWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789850896; x=1790455696; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YHVLNPODpQem+e5CBn4rhBgJZPtKTuV2DsJXEMmdlks=; b=aJ1RE4z7sInEUC2dkIKUq/N3VwsTyMcfGybkqyBpgcApKLB2ag4w6J8FV1O2FGYcbX fHWXWPXf1aBscoF3ToYgNZazHj6YNT4iZC7VFM+TDnJBsh+sg6GsqNTiF/NssC1N2PzQ spywxBgtn0Mf1duObdTJ9lyJM5gzusiU8nXBls3a7kIf/66GGe9cHmf7oQpG802Gnixv wpKJ/UapG1keXsA9/lyHFjlDoeNe6Fwp4fuEz0BnCYOnE3oIGgShdo9dRthxEgPw+G0R aTH0mx86+jhz8qxO9suAk1IiuIzSwVbzBSZNm/hh0ZNeeEU9e+ZJ/X8Nm6DK+SEXmLKc QjMQ== X-Gm-Message-State: AFuF++mYOaUNYyVEbCTqjxfJrhfpKyPX76PoioUI5jLdm2i3LI3QmsWB xduqdsl5pUuTXqOj8FoeskEbAx0f6TJogs8nnkjGg6gtsh12VOsLGSBW X-Gm-Gg: AYBFou2rhbKiPmQ51VvwS2zhZxCL6e2NjcQ3OaP/au8abiu60tvhkvvshBmJJCQvVYN sAKkOKPxZaOwdEUw9vM2Pd9JHvcPUtXJQdciDbSOLL/wznk4g73hhCONMRTxV26GI3Z4pXwgw6/ +WR/TzlU6S+kJc7N4Hx8iRpLfl1SSFCmXeUEPkg0Rkii5uA9UJCEMR9MM60QBpzUIyTVG8OSG+t SpdWKsLdbg11CX+Ggfww18fVqVpauw2+4ZFItrYVX2ULMyYngCbxIgoFHFyCUL1vvNFyyYANtnm Z60BLr5/X+0wWZqXMaQA7xWoQ5UIQdpgkALvG8A2jPn3xdGukObI98xV/zZihF1n6lWLUDbjtLa 8X0Frb9J9AsLB14Dq+ClJy1lFfD3jfFiY4wDKeT8fypndDRdYmLpkqs9MRrJmx0Q7z0J2WbJauU 32PfgFx5nRzxXLq/XMkW22wGDdD320/iDMIUujw1QFb9Cpde5A6EKhfd32zsJImIRutWWepy8pd g01Hb1WDIciTWoOVDMz0/y+o8WypxMMWdatUnva2Vju7XaTtMDIpGPfw3cwYCdUXFM2WONKygq3 K9IZqt5dYpFpA2hriIP+ X-Received: by 2002:a17:90b:2e0b:b0:39e:6c68:c78a with SMTP id 98e67ed59e1d1-39e6c68ca60mr4717671a91.64.1789850895619; Sat, 19 Sep 2026 13:48:15 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a02738654csm4043944a91.3.2026.09.19.13.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Sep 2026 13:48:15 -0700 (PDT) From: Hui Peng To: Doug Gilbert , "James E . J . Bottomley" , "Martin K . Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: sg: clean up request on error paths in sg_read() Date: Sat, 19 Sep 2026 20:48:14 +0000 Message-ID: <20260919204814.2815374-1-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In sg_read(), once sg_get_rq_mark() locates a completed Sg_request and transitions srp->done from 1 to 2, an allocation failure in kzalloc() or a user-copy fault (-EFAULT) in copy_to_user() / sg_read_oxfer() returns or jumps to free_old_hdr without calling sg_finish_rem_req(srp) and sg_remove_request(sfp, srp). Because srp->done is already 2, subsequent sg_read() calls skip the request, permanently leaking srp->bio and keeping sfp->res_in_use = 1 (blocking SG_SET_RESERVED_SIZE with -EBUSY and wedging non-SG_FLAG_NO_DXFER writes with -EDOM) until the file descriptor is closed. Always call sg_finish_rem_req(srp) and sg_remove_request(sfp, srp) under the free_old_hdr cleanup label, matching sg_new_read(). Fixes: cb59e8408381 ("[PATCH] sg.c: update") Assisted-by: LLM Signed-off-by: Hui Peng --- diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -480,8 +480,10 @@ sg_read(struct file *filp, char __user *buf, size_t count, loff_t * ppos) hp = &srp->header; old_hdr = kzalloc(SZ_SG_HEADER, GFP_KERNEL); - if (!old_hdr) - return -ENOMEM; + if (!old_hdr) { + retval = -ENOMEM; + goto free_old_hdr; + } old_hdr->reply_len = (int) hp->timeout; old_hdr->pack_len = old_hdr->reply_len; /* old, strange behaviour */ @@ -543,10 +545,10 @@ sg_read(struct file *filp, char __user *buf, size_t count, loff_t * ppos) } } else count = (old_hdr->result == 0) ? 0 : -EIO; - sg_finish_rem_req(srp); - sg_remove_request(sfp, srp); retval = count; free_old_hdr: + sg_finish_rem_req(srp); + sg_remove_request(sfp, srp); kfree(old_hdr); return retval; } -- 2.43.0