From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6C3470454 for ; Sun, 20 Sep 2026 17:05:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789923930; cv=none; b=bI7d4f/p41yVv6ZPsqPewHKK7U7TYo0vpYZfPBdOUB1lDB+Qrag4VENVJlMrL8aZNVQUbyBhkHOj6yLQbWULhsJek0Iv7jXMn7iMVCnZCtODFDCjz948T9iMcJi9OEi8pWrDYELJOJMgn97ScMgU7WdjPslZu38UDQ9bpLV11kM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789923930; c=relaxed/simple; bh=UB7DMGZ+FxW0l1Fy8c9IR09ZvHOP2nrs1Rzs5/zvHbM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HgI8uPhYBfM+i/RSDEaYbUjLOt61y0c2wzDvWhdyNl10JMefUEIKdt5t1xOMdZ8DNn4QxuAXIV70Dbl/VIYABEiCqMU6yntrl5NeJ5h7j6Bx2RsL31jYeT/FYXhADZkkeNWgQ2f3grPOcbzT0pa6NrG2HkCS40wbM2i2EIA7RgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--stanleyjhu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=q1G8OZed; arc=none smtp.client-ip=209.85.214.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--stanleyjhu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="q1G8OZed" Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2dc92350888so41236425ad.3 for ; Sun, 20 Sep 2026 10:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789923928; x=1790528728; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vC56C3EjHy57yP07NvUm+ZJd8lFbjzDpbgEVI6VNNtY=; b=q1G8OZedTUdvxYWwPF0IiNk2HTpESpBqxQsTTwA0rFEP+3qCI5Ayvjrwj55Zf+92bE GM1Sw4Gr+jZOrEx8Nj6+XZwIYjQjcqDosG+L+N5WJsvIp+0NyOAvMELIbS8xXgXMhWz3 LBk2apB4zv3beYytxuo4eJp3l0RPeZccQM4g5lus+kj6VOjGr1wDA80O0EpUR3I6wSWM /vA9wsXptYREdhDdWAZ9bFY3I2aF0Jn4i6jgHGKYxNxKUGKiZTfMEqZ3KMtu9Cv9zs6u eAYRCMmh3Jm/P4JfcUgGvWIAnafXTZnllJE3nWZRXaax7O8XMr9vi0nUKqrFsoOSWizs 3DOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789923928; x=1790528728; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vC56C3EjHy57yP07NvUm+ZJd8lFbjzDpbgEVI6VNNtY=; b=0/DV9n3alQKga5QoesESrFIQu+gb4R6XEK7IddO83GCvpzC+DT0/EFxJQ7C9uNMXN8 MbO4Dy6bkFRRSqIdPMNtjpmJ3eEDz9qzJ0/9wtRUjuHypwhX311zi1qLJIiOSSltLkSc Wa0ApjAL3FVwmp2hevxtc7wYIGI6SrmSLoZx4JQUPMP4JgShC3r6oOrm+sbMjLwPoQG7 /OqFJEi7CFOme9V+rkmUU71YQdAWoSXXxhzxdbFS60PXj+mPpWHTaUpP7/FuC+ieZHcz fSO8MIlLisG/eNtzQ7QWW1XRVQ7Uktc0WNjNDGi9+kdX0+GVAEdAfZJGdaJlN0unlQ5y nCPw== X-Forwarded-Encrypted: i=1; AKwUvBymZ9fgEzTkXq9dXKfjZ/DlDMS/QNUIiaRoD5GZwiFxeK+BEcqPjU4YavOEt61KuMP340swqmtoB/SB@vger.kernel.org X-Gm-Message-State: AFuF++mDu9coJ0B9ugIyGwDdj3cSBaARxMvSjC8owjzBzn4tro53kzi2 ooUrnDu+/DABN0C8G9tK14j9uqmFzMP0V/RCvcmkIJVA67bjKYJbdpaZSNsUTsOSW13vUI+g6yT /YYSSSwg+OOrxbjDplaFnQQ== X-Received: from plao21.prod.google.com ([2002:a17:903:3015:b0:2dd:4fa9:1919]) (user=stanleyjhu job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:2447:b0:2db:5c0a:f184 with SMTP id d9443c01a7336-2ddb1b78d26mr124832455ad.17.1789923928078; Sun, 20 Sep 2026 10:05:28 -0700 (PDT) Date: Mon, 21 Sep 2026 01:05:26 +0800 In-Reply-To: <20260920-fix-ufs-rpmb-v1-1-560b842c589d@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260920-fix-ufs-rpmb-v1-1-560b842c589d@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog Message-ID: <20260920170526.4039553-1-stanleyjhu@google.com> Subject: Re: [PATCH] scsi: ufs: rpmb: register and unregister the ufs_rpmb bus From: Stanley Jhu To: Dmitry Baryshkov Cc: Stanley Jhu , Alim Akhtar , Avri Altman , Bart Van Assche , "James E.J. Bottomley" , "Martin K. Petersen" , Can Guo , Bean Huo , Jens Wiklander , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Sun, 20 Sep 2026 17:50:18 +0300, Dmitry Baryshkov wrote: > The ufs_rpmb bus isn't registered in the device framework, so any > attempt to register RPMB devices on UFS will fail with: > > bus_add_device: cannot add device 'ufs_rpmb0' to unregistered bus 'ufs_rpmb' > ufshcd-qcom 1d84000.ufshc: Failed to register UFS RPMB device 0 > > Add module_init() / exit() functions to handle bus registration and > unregistration. We have an existing patch on the list addressing this from the opposite direction (`[PATCH v5 3/3]`, Reviewed-by Bean Huo) [1]: Since ufs_rpmb_bus_type declares no .match and no .probe and consumers access RPMB devices via /sys/class/rpmb/, patch 3/3 drops ufs_rpmb_bus_type (leaving ufs_rpmb->dev.bus NULL) rather than registering an empty bus. Could you take a look at [1] and let us know which approach you prefer? [1] https://lore.kernel.org/linux-scsi/20260914144943.2571104-1-stanleyjhu@google.com/