From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4183C1DDC38 for ; Fri, 25 Sep 2026 07:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790320680; cv=none; b=iwShp2yIycYzYiGnEn8C9/0cC0vomvmQNdKUjUkZLd38BSSeDzuad1kPD+r/rX2h4s/b/JLCITQ7qI5UklfmlRBtvXLkNd8t6LToI9N32Qj8ThmU9mgodeWIsfDdNAL3dy/biYvHhwlARJ40VaTeyR4+OapYKPR70EMW/b/zp5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790320680; c=relaxed/simple; bh=XA4iBFKCR37pE0sN4PjLyTLgCJfHVg7duKkrfX46Ykg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WRMzz259UksAVf3HQZKC3OURh4BeSphmQM5mpFQXhpi9qVTrjNDGrELpLTy/WS4/OJkkgtjUYVHgtZkB7Ok9N/PaAidr5ip1oj9743G1zzb9QWEhTN2pyR6kQRI1RtxyEl67hjGzQ/I0x7K3N0y/958S6Hl944YNmapv+MnGEaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jle+QLE6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jle+QLE6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 858A81F00893; Fri, 25 Sep 2026 07:17:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790320679; bh=DmSJo+IS60cgMv7Eb2KKQvmyf5Qjm7t7McvDtM2omzA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Jle+QLE6LbRk3DrllVL81pMyVk317DX7v/2LyZKBtlQ0OIHV1+ECi33rnydJW391D nHietiNrkqJ0ldAHfGACf4MXzk9aKr5jN+0PS+zklgSXEiWj8SNtgxFgwXKnwaiY0Y JYq852GeTaVRyTehXp5P8LDQh1vatCVuU3VpLToKu04Ddt794Ajc3U20MvKaVOoiur oBteWVnm6GsHTFYXzeQvlckmFMZHkR5qHBXwHghKImhDgHBN92aFkgmltDpX9+SQN7 8+RacIBrPgqB8PlQekUI19GDUZh6YQAsb9K1WWXfEkhZcdUZJvChCv8G0qDGAYRLdh ia7X2PtPm7xlA== From: Niklas Cassel To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, Damien Le Moal , John Garry , Niklas Cassel Subject: [PATCH v7 07/11] scsi: scsi_debug: Do not write a partial physical block to a zoned device Date: Fri, 25 Sep 2026 09:17:34 +0200 Message-ID: <20260925071726.140915-20-cassel@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260925071726.140915-13-cassel@kernel.org> References: <20260925071726.140915-13-cassel@kernel.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2895; i=cassel@kernel.org; h=from:subject; bh=XA4iBFKCR37pE0sN4PjLyTLgCJfHVg7duKkrfX46Ykg=; b=owGbwMvMwCV2MsVw8cxjvkWMp9WSGLK2KQhF2/R03fy0Kn7rFm6bG1XR5vMab0S9+C9zbe/n+ RdbpVRyO0pZGMS4GGTFFFl8f7jsL+52n3Jc8Y4NzBxWJpAhDFycAjCRsExGhmcneByfrDyfV/O2 RkGFc8W7mY9mz04yP9OodjpzSudFXk9GhqOsbuVLXFhEO0z872xdWfL36PL5Fwwuppvyf86bsfu BGA8A X-Developer-Key: i=cassel@kernel.org; a=openpgp; fpr=5ADE635C0E631CBBD5BE065A352FE6582ED9B5DA Content-Transfer-Encoding: 8bit do_device_access() copies one logical block at a time and stops at the first short copy, so a data-out buffer smaller than the transfer length of the command can leave part of a physical block written. An initiator can arrange that with SG_IO. That is acceptable everywhere but a sequential write required zone, where ZBC-3 r06 (T10/BSR INCITS 579), 4.5.3.3.2, requires a write to end on a physical block boundary. For such a zone, stop at the last whole physical block that the buffer holds. The bytes left over are not written, and are reported to the initiator as part of the residual. Assisted-by: LLM Reviewed-by: Damien Le Moal Signed-off-by: Niklas Cassel --- Tested with: modprobe scsi_debug zbc=managed sector_size=512 physblk_exp=3 \ zone_size_mb=8 dev_size_mb=128 zone_nr_conv=2 issuing a sixteen logical block WRITE(16) through SG_IO with a buffer of twelve blocks. To a sequential write required zone it now transfers eight blocks, one whole physical block, and reports the remaining 2048 bytes as the residual; before this patch it transferred twelve. To a conventional zone it still transfers all twelve and reports no residual. With physblk_exp=0 an eight block write with a buffer of one block still transfers one block, wherever it is addressed. --- drivers/scsi/scsi_debug.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 3ed599a606ba..2c6a9e17e4a8 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -4273,6 +4273,8 @@ static int do_device_access(struct sdeb_store_info *sip, struct scsi_cmnd *scp, u64 block; enum dma_data_direction dir; struct scsi_data_buffer *sdb = &scp->sdb; + struct scsi_device *sdp = scp->device; + struct sdebug_dev_info *devip = (struct sdebug_dev_info *)sdp->hostdata; u8 *fsp; int i, total = 0; @@ -4300,6 +4302,25 @@ static int do_device_access(struct sdeb_store_info *sip, struct scsi_cmnd *scp, fsp = sip->storep; + /* + * A write to a sequential write required zone has to end on a physical + * block boundary, so if the data-out buffer does not hold all of the + * data that the command asks for, write up to the last whole physical + * block that it does hold. What is left over is reported as part of + * the residual. + */ + if (do_write && sdebug_dev_is_zoned(devip)) { + struct sdeb_zone_state *zsp = zbc_zone(devip, lba); + + if (zsp->z_type == ZBC_ZTYPE_SWR) { + u32 avail = (sdb->length - sg_skip) + >> ilog2(sdebug_sector_size); + + if (avail < num) + num = round_down(avail, 1U << sdebug_physblk_exp); + } + } + block = do_div(lba, sdebug_store_sectors); /* Only allow 1x atomic write or multiple non-atomic writes at any given time */ -- 2.55.0