Re: [RFC PATCH 3/3] scsi: lpfc: Add KUnit tests for mailbox wait ownership

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] scsi: lpfc: missing -I$(src) in Makefile causes test build failure
--

commit 58bda9d071979b03b73e5787531c133618f4a219
Author: Artem Dinaburg <artem@trailofbits.com>

scsi: lpfc: Add KUnit tests for mailbox wait ownership

This commit adds KUnit tests for synchronous LPFC mailbox wait and
completion ownership. It replaces the mailbox issue callback to exercise
behavior without physical LPFC hardware and checks various error and
timeout scenarios.

> diff --git a/drivers/scsi/lpfc/Makefile b/drivers/scsi/lpfc/Makefile
> index bbd1faf41e806..d2b1f0990b7d7 100644
> --- a/drivers/scsi/lpfc/Makefile
> +++ b/drivers/scsi/lpfc/Makefile
> @@ -34,3 +34,5 @@ lpfc-objs := lpfc_mem.o lpfc_sli.o lpfc_ct.o lpfc_els.o \
>  	lpfc_hbadisc.o	lpfc_init.o lpfc_mbox.o lpfc_nportdisc.o   \
>  	lpfc_scsi.o lpfc_attr.o lpfc_vport.o lpfc_debugfs.o lpfc_bsg.o \
>  	lpfc_nvme.o lpfc_nvmet.o lpfc_vmid.o
> +
> +lpfc-$(CONFIG_LPFC_MBOX_KUNIT_TEST) += tests/mbox_kunit.o

[Severity: Low]
Will this cause a build failure when compiling in-tree with
CONFIG_LPFC_MBOX_KUNIT_TEST=y? The Makefile appends the test object to
lpfc-y, but does not appear to add ccflags-y += -I$(src) to allow the
subdirectory to find the parent headers.

> diff --git a/drivers/scsi/lpfc/tests/mbox_kunit.c b/drivers/scsi/lpfc/tests/mbox_kunit.c
> new file mode 100644
> index 0000000000000..2bdc2d5fcadaf
> --- /dev/null
> +++ b/drivers/scsi/lpfc/tests/mbox_kunit.c
[ ... ]
> +#include <scsi/scsi_transport_fc.h>
> +
> +#include "lpfc_hw4.h"
> +#include "lpfc_hw.h"
> +#include "lpfc_sli.h"
> +#include "lpfc_sli4.h"

[Severity: Low]
Since these includes use paths relative to the parent directory but lack the
../ prefix, don't they rely on an explicit -I directive in the Makefile to
compile correctly? Without it, the compiler will look in the tests directory
first and fail with a missing file error.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1790968549.git.artem@trailofbits.com?part=3