From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, John Garry <john.g.garry@oracle.com>,
Marco Elver <elver@google.com>,
llvm@lists.linux.dev
Subject: Re: [PATCH v4 7/8] scsi: scsi_debug: Improve lock context annotations
Date: Wed, 7 Oct 2026 15:14:11 +0200 [thread overview]
Message-ID: <20261007131411.GE30647@lst.de> (raw)
In-Reply-To: <765bf3683555f3d7fbe8510cde1eb50d5f6d0c6f.1791349129.git.bvanassche@acm.org>
On Tue, Oct 06, 2026 at 10:07:29PM -0700, Bart Van Assche wrote:
> static inline void
> sdeb_read_lock(rwlock_t *lock)
> + __acquires_shared(lock)
> + __context_unsafe(/*conditional locking*/)
> {
> - if (sdebug_no_rwlock)
> - __acquire(lock);
> - else
> + if (!sdebug_no_rwlock)
> read_lock(lock);
> }
Is there no way we can make the spare-style __acquire/__release work for
clang? That would be this and similar patterns so much better and
safer than the blanket __context_unsafe.
next prev parent reply other threads:[~2026-10-07 13:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 5:07 [PATCH v4 0/8] scsi_debug: Enable lock context analysis Bart Van Assche
2026-10-07 5:07 ` [PATCH v4 1/8] scsi: scsi_debug: Fix a locking bug in resp_write_same() Bart Van Assche
2026-10-07 5:07 ` [PATCH v4 2/8] scsi: scsi_debug: Split resp_write_same() Bart Van Assche
2026-10-07 5:07 ` [PATCH v4 3/8] scsi: scsi_debug: Split corrupt_lbas() Bart Van Assche
2026-10-07 5:07 ` [PATCH v4 4/8] scsi: scsi_debug: Split resp_read_dt0() Bart Van Assche
2026-10-07 5:07 ` [PATCH v4 5/8] scsi: scsi_debug: Split resp_write_dt0() Bart Van Assche
2026-10-07 13:12 ` Christoph Hellwig
2026-10-07 20:08 ` Bart Van Assche
2026-10-08 7:09 ` Christoph Hellwig
2026-10-07 5:07 ` [PATCH v4 6/8] scsi: scsi_debug: Split resp_atomic_write() Bart Van Assche
2026-10-07 13:12 ` Christoph Hellwig
2026-10-07 5:07 ` [PATCH v4 7/8] scsi: scsi_debug: Improve lock context annotations Bart Van Assche
2026-10-07 5:17 ` sashiko-bot
2026-10-07 13:14 ` Christoph Hellwig [this message]
2026-10-07 14:31 ` Marco Elver
2026-10-07 20:10 ` Bart Van Assche
2026-10-08 7:10 ` Christoph Hellwig
2026-10-07 5:07 ` [PATCH v4 8/8] scsi: core: Enable lock context analysis for the scsi_debug driver Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007131411.GE30647@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=elver@google.com \
--cc=john.g.garry@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox