From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3CEF3D1CA5 for ; Thu, 8 Oct 2026 07:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791443452; cv=none; b=GY6hx3Yz/x7mugTrOgXSoLuW8jlSplyvv/xvnhEroFnT96+vl7BU2C9U6TdFHO4mov+qkzRzywkDLwEyn2jI89rYprPRnrEE430ERDmqQbFNp4fugPeSFV+4SuAM/yX/JAY2sOKwaqHOcM1G++A4FEJmfgoYHcitZc1VtDkqowg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791443452; c=relaxed/simple; bh=FeZICw99s+k2He4rwIBLTy656mhd4BVV478wspmPBKA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vcl9MoTpIwrMKfItMcMt2pnD1D60YGECplAmQjKBcVJh2VwpC9ZrLOTD8VIEfIVdh/yxCnHS51d6F8uzsihbW66OkzhpkE1e2BN62vrzeliod34r/OqQVtl5Idxrf8buVvZthWxSgommw1zbe6hTrZarpUgtfKquHKtiF43LJV8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 1511068BEB; Thu, 8 Oct 2026 09:10:46 +0200 (CEST) Date: Thu, 8 Oct 2026 09:10:45 +0200 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , "Martin K . Petersen" , linux-scsi@vger.kernel.org, John Garry , Marco Elver , llvm@lists.linux.dev Subject: Re: [PATCH v4 7/8] scsi: scsi_debug: Improve lock context annotations Message-ID: <20261008071045.GB30898@lst.de> References: <765bf3683555f3d7fbe8510cde1eb50d5f6d0c6f.1791349129.git.bvanassche@acm.org> <20261007131411.GE30647@lst.de> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Oct 07, 2026 at 01:10:27PM -0700, Bart Van Assche wrote: > Do you like the alternative below better? If so then I will replace > patch 7/8 with the changes below. Much better, although I'd drop the pointless inversion of the condition and keep the flow as in the old version: static inline void sdeb_read_lock(rwlock_t *lock) __acquires_shared(lock) { if (sdebug_no_rwlock) __acquire_shared(lock); else read_lock(lock); }