From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.197 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792484481; b=g/2bNd8FMVApNB1fSLGVDWKezrWAoKuYQvGT8/PzNA+OImQhw2yTsb527bL+FsXc6ETX 3Qrvra21qqkFna3l2k0L02DuE5OUA4jyThUohAwUzp0/xogRj2XU+MhX15xgnzeKgiESp I2SBDCtTD8KX82b1G0i6pMqkGJLhoLtatgZDQi1ujnTGbbDkNr9xq2l363am09AsfBeKM oGDIR8mYX+b7PiepoDHIpVhxLOAuL4l98kmmv4XjMwEqsC5tJ60q+LsbJQ4cRIIbfOeEk 5s8WukGz4T2pKz2QKSTf+QEloLlQKjFSRoYo4GGsnCR5S7/kgkTZjs0XXyVTOMXN/rg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792484481; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=kUb4PjDJE3jmbIXPSQFsF3M/wgWILtNCIkP/sO++VrQ=; b=zbx+Wtr/USjNevcPgs31Kr29mWvwgwemAoOfvoXwHmM2gBmxBatQGQXe+XNduKGfuk13 2XFo9WDl4Vl+YG2dv7OhPJhXp6gBehtP2WA9AefvrooULHOAOQQOp3mqnVjEkuWMEUA3t cax+EBbMgrHxNMOIVFhHdJniJkhO44tOQE6gs4bti6HYMf84AkNQlz48WUNDEuKKgWewX ufmkC/wVx6x0li9QMeiJ3QkuxnMfsOB1Z5/1TYoXzlZIik+6Qsd1FJ1FmC8+HlqAJ09yS usQ5ENEUQBOP0Y3eu6z8WsqMntISdDs5idH4GkHwjUvQuMnfPrsAWOp/kx9IWsBPgyw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--stanleyjhu.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=NWyv+XgA; arc=none smtp.remote-ip=209.85.215.197 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F1E0606A331 for ; Tue, 20 Oct 2026 08:21:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5F1E0606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--stanleyjhu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=NWyv+XgA Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cd5fd34fee0so1997719a12.3 for ; Tue, 20 Oct 2026 01:21:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792484481; x=1793089281; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kUb4PjDJE3jmbIXPSQFsF3M/wgWILtNCIkP/sO++VrQ=; b=NWyv+XgAyn89Cjyc1kpyFtEvrseSFaaSjvJKD00zUxxAqRwBDNLtDh7+0yKZ2rayjb b7pJ4qSmGrbQs8tV8jYWtw8yzkEI7A7bjoBckHaNcEwjfmPmkk1L5aLmcxqeE1rYjqP1 GjemQvDzEjslx97UJ6jiiFrT94X5dPgIG2LlKYmx53KFctsNjEkcp2lN9Pfmn2IiUctL AYxU+d1EO8dBOdNd1q+6cMeMAgXry2ZEBeVTxwP/3FC+17HXXMaQG487bl9K/lgwXfmB lV3QGv/DxOmcV0LKaJhrjXJzA/uIn7PJku5X7L7Fzx/yo3nNx7+lB0j9lyqkLD/oN2UF 7y2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792484481; x=1793089281; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kUb4PjDJE3jmbIXPSQFsF3M/wgWILtNCIkP/sO++VrQ=; b=ciN4eV3nlaUE7I7aXYcto/Ah9EOcngn/zK1M6pxMDMjFRFXdileaxUNpYDK8rBCUVj buopqwB+fNciifqQ5uzzhu5xC3vzN26SGox23NvjuCsgYsJc3vOY6ccqdKjTKdmPgt07 U03aVsAg3Vz+8ZAgXjxjIHuedLairN5t7p9q7Dbxm5dz4PodgH2KFfwNBzYUm9HZ4jyX VsbcpFd6X30rAGM0rqHHT06d2OET1d0xtYIJ8x55smw6dsvd/UNgOoI9eG32vMEoBVXI GhbN9VnQuq4rvrn/xOHfprhWmrIZg2S0dTxuJKgiqzYwvLYkVbrQcal6XOIqGx/kiH9S k0Xg== X-Forwarded-Encrypted: i=1; AKwUvBx7CpmcL+0g0PCMeATNZlxU3g7D55rK7S9w+G1Vu7bM+G2wGrsIa7uvWlxxDCkeGDDVUO6ah6zw6PQ9@vger.kernel.org X-Gm-Message-State: AFq9FYLb9+EWtyVxyQu1sNgwOvvaSJTeyRxXiM9gIRtSfix3GEg7uJ39 /T3/dlbsp6CqZXXj9Zx1ccEU0COwHWdCFnZBjaeSyBjjGUJR6IVnEs+/f0qhkTxGM65ZU+hziQ5 zCAVgWVIwrRXMDF7aDGMI0A== X-Received: from pfbct6.prod.google.com ([2002:a05:6a00:f86:b0:8a0:4085:d831]) (user=stanleyjhu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:730c:b0:3e1:e757:205e with SMTP id adf61e73a8af0-3e225f9fd41mr8502692637.42.1792484480229; Tue, 20 Oct 2026 01:21:20 -0700 (PDT) Date: Tue, 20 Oct 2026 16:21:07 +0800 In-Reply-To: <20261020082110.3511797-1-stanleyjhu@google.com> X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261020082110.3511797-1-stanleyjhu@google.com> X-Mailer: git-send-email 2.56.0.212.g129ede20d9-goog Message-ID: <20261020082110.3511797-5-stanleyjhu@google.com> Subject: [PATCH v3 4/7] scsi: ufs: core: Use ufshcd_clear_outstanding_reqs() in ufshcd_eh_timed_out() From: Stanley Jhu To: "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: "James E . J . Bottomley" , Bart Van Assche , Alim Akhtar , Bean Huo , Peter Wang , Can Guo , linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ufshcd_eh_timed_out() has its own copy of the code that clears the timed-out tag in hba->outstanding_reqs. Use ufshcd_clear_outstanding_reqs() instead. No functional change. Cc: stable@vger.kernel.org Reviewed-by: Bean Huo Reviewed-by: Peter Wang Signed-off-by: Stanley Jhu --- drivers/ufs/core/ufshcd.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 778932298e27..03efbd85bba9 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -9651,12 +9651,9 @@ static enum scsi_timeout_action ufshcd_eh_timed_out(struct scsi_cmnd *scmd) */ if (!test_bit(SCMD_STATE_COMPLETE, &scmd->state)) { if (!hba->mcq_enabled) { - unsigned long flags; struct request *rq = scsi_cmd_to_rq(scmd); - spin_lock_irqsave(&hba->outstanding_lock, flags); - __clear_bit(rq->tag, &hba->outstanding_reqs); - spin_unlock_irqrestore(&hba->outstanding_lock, flags); + ufshcd_clear_outstanding_reqs(hba, BIT(rq->tag)); } if (ufshcd_is_scsi_cmd(scmd)) { -- 2.56.0.212.g129ede20d9-goog