From: Eric Biggers <ebiggers@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulfh@kernel.org>, Abel Vesa <abelvesa@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K. Petersen" <mkp@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/3] soc: qcom: ice: Add runtime PM support
Date: Sat, 24 Oct 2026 11:34:24 -0700 [thread overview]
Message-ID: <20261024183424.GE2553@quark> (raw)
In-Reply-To: <sashiko-outbox-181342@kernel.org>
On Thu, Oct 22, 2026 at 10:34:40AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 5 potential issue(s) to consider:
> - [High] soc: qcom: ice: unclocked MMIO access in qcom_ice_enable() when !CONFIG_PM
> - [High] soc: qcom: ice: unbalanced runtime PM refcount in qcom_ice_enable()
> - [High] soc: qcom: ice: clock and runtime PM leak on probe failure or unbind
> - [High] soc: qcom: ice: broken pm_runtime return handling in qcom_ice_suspend()
> - [High] soc: qcom: ice: skipped HWKM re-init and unclocked restore across system PM
I'll review this more carefully once these issues have been addressed.
- Eric
prev parent reply other threads:[~2026-10-24 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 9:51 [PATCH 0/3] ICE: Enable runtime PM support Kuldeep Singh
2026-10-22 9:51 ` [PATCH 1/3] mmc: sdhci-msm: Enable ICE before enabling crypto support Kuldeep Singh
2026-10-24 18:29 ` Eric Biggers
2026-10-22 9:51 ` [PATCH 2/3] ufs: ufs-qcom: " Kuldeep Singh
2026-10-22 9:51 ` [PATCH 3/3] soc: qcom: ice: Add runtime PM support Kuldeep Singh
2026-10-22 10:34 ` sashiko-bot
2026-10-24 18:34 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024183424.GE2553@quark \
--to=ebiggers@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=abelvesa@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andersson@kernel.org \
--cc=konradybcio@kernel.org \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mkp@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox