From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793115854; b=gXEq9gnOGCO5kUBn5dgmaLgNmPS+RcqDRXKuLedW0QRc2Ro18XGfBIFpYINfgcywwiT+ UKHYapk0xzl7YjmqAR755lrI8tr6y0AEJoDg/sNAz6i9vWajX2qx9WMnKyPygR8Bq9vgJ d1Rr2N/HHyoa0nNCffCEuwX6lrnbU6bkQqtiwe9u0KOcrQdbLbVHpB4CMaov8nEXPn7Kg +rO0xMRe1zNw9uTM5QoO+91z0zwbocwB6L28KGKpDJtrDdu/15vlMBuwE3rPtCp9U3lTz T5huqo67ueyV/BBWPe4gJB6CCLlxaJC+A+ZwDS3sLP17Pt85R467c1n3yaisN7+nBJw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793115854; h=Received:DKIM-Signature:Received:Message-ID:User-Agent:Date:From:To: Cc:Subject:References:MIME-Version:Content-Type; bh=KzGA3Z1wHw/pEoG+sL3nupeeb8x6YGTMS4RDHQzgvgY=; b=tc54JVH3cTEG+R7G+NJ6y5lrXm0QMexnNN/FAwN9l/xHGFPP0uaqtHjqojAZzJgz3nWw tlAuRH4r0+OKNhsWqGtbr63Jb5fvmhf8wgYggN+aIb0gSzgeMYA0tipkyaPISpmfN8QlV uH5A3q6o2JL0yUYKvVr8OTO0l4cDJ8ZxpfN0ijwBxzhvRfnAmWxnX34ktBkk7rwKPabgg o+Bt7ZEgTB4MVwr0ZjSe1pMwkczN8KMYal4lXdZpI07puwSkoGv18Ey/gr6G4GthnUGQJ vMxh7+LhCjZJwaXhT3GtB0SyNgfj7qlQZLxHugv8AJdsF8HPSjSFc3vU/Pc0WxvvVtA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=AfWSo6hV; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C57C606A325; Tue, 27 Oct 2026 15:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=AfWSo6hV Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE7F31F01829; Tue, 27 Oct 2026 15:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793115853; bh=KzGA3Z1wHw/pEoG+sL3nupeeb8x6YGTMS4RDHQzgvgY=; h=Date:From:To:Cc:Subject:References; b=AfWSo6hVC8lFb2WltHtSejhRNb8UVs4QhxXiq9vQdf1BIByfe9oE6+YTcNLAIj/ij 3gpWorjlfL03ffDe/a0Y7zrHwNXVdr1DR/zvjYR4BpAak7GpvDRWT4ox+fq1KeA0qZ +WGKSFcSgYCjnPSZerKO5mRsxr8GKU6SWwT2XhPZCzwR6uNubRVKWAWTnDFYdBJf1Z zjqlXN1fpTmDt8g1X9LtEpEsz+J0GOuyGwQ8YvurX3hCaxpzEsdVHMSLEB+A3VZuD3 yNTB+rSiUQQwCZ4Tx07KoB4EjjXu+sClnPzBaDmhQjDD3Wc9fmInB+d1UCt6ifIqzI 3oU5XNtcbw1LA== Received: from rostedt by gandalf with local (Exim 4.100.1) (envelope-from ) id 1xLjLR-000000078gI-05dC; Tue, 27 Oct 2026 11:44:13 -0400 Message-ID: <20261027154412.834382801@kernel.org> User-Agent: quilt/0.69 Date: Tue, 27 Oct 2026 11:37:00 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Vineeth Pillai , Peter Zijlstra , Aaron Conole , Alex Deucher , Alexei Starovoitov , Anna-Maria Behnsen , Borislav Petkov , Chanwoo Choi , =?UTF-8?q?Christian=20K=C3=B6nig?= , Daniel Borkmann , Danilo Krummrich , Dave Hansen , David Airlie , "David S. Miller" , Eelco Chaudron , Eric Dumazet , Frederic Weisbecker , Ilya Maximets , Ingo Molnar , Jakub Kicinski , "James E.J. Bottomley" , Jesper Dangaard Brouer , Jiri Pirko , John Fastabend , Jon Maloy , Koby Elbaz , Konstantin Sinyuk , Kyungmin Park , Maarten Lankhorst , Marcelo Ricardo Leitner , "Martin K. Petersen" , Matthew Brost , Maxime Ripard , MyungJoo Ham , Oded Gabbay , Paolo Abeni , Philipp Stanner , Simona Vetter , Sumit Semwal , Thomas Gleixner , Thomas Zimmermann , tipc-discussion@lists.sourceforge.net, Tung Quang Nguyen , Xin Long , x86@kernel.org, amd-gfx@lists.freedesktop.org, bpf@vger.kernel.org, dev@openvswitch.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sctp@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 2/9] accel/habanalabs: Use trace_call__##name() at guarded tracepoint call sites References: <20261027153658.703730257@kernel.org> X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Vineeth Pillai Replace trace_foo() with the new trace_call__foo() at sites already guarded by trace_foo_enabled(), avoiding a redundant static_branch_unlikely() re-evaluation inside the tracepoint. trace_call__foo() calls the tracepoint callbacks directly without utilizing the static branch again. Original v2 series: https://lore.kernel.org/linux-trace-kernel/20260323160052.17528-1-vineeth@bitbyteword.org/ Parts of the original v2 series have already been merged in mainline. This patch is being reposted as a follow-up cleanup for the remaining unmerged pieces. Link: https://patch.msgid.link/20260515135914.2238789-1-vineeth@bitbyteword.org Suggested-by: Steven Rostedt Suggested-by: Peter Zijlstra Signed-off-by: Vineeth Pillai (Google) Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Steven Rostedt --- drivers/accel/habanalabs/common/device.c | 9 +++++---- drivers/accel/habanalabs/common/mmu/mmu.c | 3 ++- drivers/accel/habanalabs/common/pci/pci.c | 6 ++++-- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/accel/habanalabs/common/device.c b/drivers/accel/habanalabs/common/device.c index 09b27bac3a31..68c6f973d53f 100644 --- a/drivers/accel/habanalabs/common/device.c +++ b/drivers/accel/habanalabs/common/device.c @@ -132,8 +132,9 @@ static void *hl_dma_alloc_common(struct hl_device *hdev, size_t size, dma_addr_t } if (trace_habanalabs_dma_alloc_enabled() && !ZERO_OR_NULL_PTR(ptr)) - trace_habanalabs_dma_alloc(&(hdev)->pdev->dev, (u64) (uintptr_t) ptr, *dma_handle, - size, caller); + trace_call__habanalabs_dma_alloc(&(hdev)->pdev->dev, + (u64) (uintptr_t) ptr, + *dma_handle, size, caller); return ptr; } @@ -2656,7 +2657,7 @@ inline u32 hl_rreg(struct hl_device *hdev, u32 reg) u32 val = readl(hdev->rmmio + reg); if (unlikely(trace_habanalabs_rreg32_enabled())) - trace_habanalabs_rreg32(&(hdev)->pdev->dev, reg, val); + trace_call__habanalabs_rreg32(&(hdev)->pdev->dev, reg, val); return val; } @@ -2674,7 +2675,7 @@ inline u32 hl_rreg(struct hl_device *hdev, u32 reg) inline void hl_wreg(struct hl_device *hdev, u32 reg, u32 val) { if (unlikely(trace_habanalabs_wreg32_enabled())) - trace_habanalabs_wreg32(&(hdev)->pdev->dev, reg, val); + trace_call__habanalabs_wreg32(&(hdev)->pdev->dev, reg, val); writel(val, hdev->rmmio + reg); } diff --git a/drivers/accel/habanalabs/common/mmu/mmu.c b/drivers/accel/habanalabs/common/mmu/mmu.c index 6c7c4ff8a8a9..dd8b6fb3aa1f 100644 --- a/drivers/accel/habanalabs/common/mmu/mmu.c +++ b/drivers/accel/habanalabs/common/mmu/mmu.c @@ -263,7 +263,8 @@ int hl_mmu_unmap_page(struct hl_ctx *ctx, u64 virt_addr, u32 page_size, bool flu mmu_funcs->flush(ctx); if (trace_habanalabs_mmu_unmap_enabled() && !rc) - trace_habanalabs_mmu_unmap(&hdev->pdev->dev, virt_addr, 0, page_size, flush_pte); + trace_call__habanalabs_mmu_unmap(&hdev->pdev->dev, virt_addr, 0, + page_size, flush_pte); return rc; } diff --git a/drivers/accel/habanalabs/common/pci/pci.c b/drivers/accel/habanalabs/common/pci/pci.c index 81cbd8697d4c..12663e8e12e0 100644 --- a/drivers/accel/habanalabs/common/pci/pci.c +++ b/drivers/accel/habanalabs/common/pci/pci.c @@ -123,7 +123,8 @@ int hl_pci_elbi_read(struct hl_device *hdev, u64 addr, u32 *data) pci_read_config_dword(pdev, mmPCI_CONFIG_ELBI_DATA, data); if (unlikely(trace_habanalabs_elbi_read_enabled())) - trace_habanalabs_elbi_read(&hdev->pdev->dev, (u32) addr, val); + trace_call__habanalabs_elbi_read(&hdev->pdev->dev, + (u32) addr, val); return 0; } @@ -186,7 +187,8 @@ static int hl_pci_elbi_write(struct hl_device *hdev, u64 addr, u32 data) if ((val & PCI_CONFIG_ELBI_STS_MASK) == PCI_CONFIG_ELBI_STS_DONE) { if (unlikely(trace_habanalabs_elbi_write_enabled())) - trace_habanalabs_elbi_write(&hdev->pdev->dev, (u32) addr, val); + trace_call__habanalabs_elbi_write(&hdev->pdev->dev, + (u32) addr, val); return 0; } -- 2.53.0