From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793211878; b=S3ewKB+RzomIpldox7ckUfMFZhRZs0O+ayAT8eemCoDIV5v1osvloChVSet+8PKl3SBV ePmEoNI75RX/V68+1XrOAv1PAN4tv19HU2ovXT6wtuGrPLU9nstn7eShAF3DIFJsvY+fa Bv6a4BuNyYSZHvY9lWnz8HlqRmYAe0gXy5puf9pEG7ZyRYSQZkSUuMKnDTS8ulZNuEEEM eO87rNYcmjqihbwMGRYwwIbVOI78/mJNF3j1VcRL0atjeGYBGBV7uFFH2gWeNsZ9ayeug 5SF0kUpo0VqJwIO75JGdJZtiBKJoR2pY3tMwGKO2lVgtTebT4MMtfZhOlRuImVbfODg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793211878; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=or8+JLMxiZBPAbx6o4e8NET7jv5HaVgGCgnWz6oodK8=; b=HRDJi8puiUqmt//Z5Lifj8Vd7VXAAZtdenCXglyhnntKW1T5hdqomQE2z96lE3FblS5l YrU77LDlyDFAKxIHL4RlgpPtaMhRMypvO3xyBUd8XTVhheQkcacrS9C81uDitD9rhHg3m vYHGGiPVpK3iwj6NgEKbUAJwzFZpnK7oO+n/h2RUheBFDpbjlcqeMckY8cY6SrMlfpb8z jXdFSFzZBEz68jK+pTaLT8BlUWuQY+guvJgc3lb+b1HWnARm8SZCevzf9OGtzrX4Tr8JJ JYwCQ1AEhbId0Zzl3j0yk//GkWbY4y4dvCGF0GeYGRN+1SfvPnadq1+KXDs7qIJJaLA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FrMkiKcx; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED4C8606A31C; Wed, 28 Oct 2026 18:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=FrMkiKcx Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46B071F01825; Wed, 28 Oct 2026 18:24:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793211877; bh=or8+JLMxiZBPAbx6o4e8NET7jv5HaVgGCgnWz6oodK8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FrMkiKcxGezg51JX8Re+YsM6RtA0x7t4rtuyGtV2SzW1o0+TW/nT9Dy6NKkXkDjjQ Q+7Y15nhSbT+Rh6YJ6/joPNYgMVIl61jZ1lsv/IEB16SjABO/ZwsMBGJmIBEdgHyku 4KJUGPQp0oZE6gNeKgtLgAH9wAgEIScPTUYdkfxc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daniil Stas , Guenter Roeck , Chris Healy , Linus Walleij , "Martin K. Petersen" , Bart Van Assche , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, linux-hwmon@vger.kernel.org, "Nobuhiro Iwamatsu (CIP)" , Sasha Levin Subject: [PATCH 5.15 532/571] hwmon: (drivetemp) Fix driver producing garbage data when SCSI errors occur Date: Wed, 28 Oct 2026 18:01:19 +0100 Message-ID: <20261028170020.654917731@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170008.009143722@linuxfoundation.org> References: <20261028170008.009143722@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daniil Stas commit 82163d63ae7a4c36142cd252388737205bb7e4b9 upstream. scsi_execute_cmd() function can return both negative (linux codes) and positive (scsi_cmnd result field) error codes. Currently the driver just passes error codes of scsi_execute_cmd() to hwmon core, which is incorrect because hwmon only checks for negative error codes. This leads to hwmon reporting uninitialized data to userspace in case of SCSI errors (for example if the disk drive was disconnected). This patch checks scsi_execute_cmd() output and returns -EIO if it's error code is positive. Fixes: 5b46903d8bf37 ("hwmon: Driver for disk and solid state drives with temperature sensors") Signed-off-by: Daniil Stas Cc: Guenter Roeck Cc: Chris Healy Cc: Linus Walleij Cc: Martin K. Petersen Cc: Bart Van Assche Cc: linux-kernel@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-ide@vger.kernel.org Cc: linux-hwmon@vger.kernel.org Link: https://lore.kernel.org/r/20250105213618.531691-1-daniil.stas@posteo.net [groeck: Avoid inline variable declaration for portability] Signed-off-by: Guenter Roeck Signed-off-by: Nobuhiro Iwamatsu (CIP) Signed-off-by: Sasha Levin --- drivers/hwmon/drivetemp.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/drivetemp.c b/drivers/hwmon/drivetemp.c index 5bac2b0fc7bb6..b3de637a3a1f2 100644 --- a/drivers/hwmon/drivetemp.c +++ b/drivers/hwmon/drivetemp.c @@ -165,6 +165,7 @@ static int drivetemp_scsi_command(struct drivetemp_data *st, { u8 scsi_cmd[MAX_COMMAND_SIZE]; int data_dir; + int err; memset(scsi_cmd, 0, sizeof(scsi_cmd)); scsi_cmd[0] = ATA_16; @@ -192,9 +193,12 @@ static int drivetemp_scsi_command(struct drivetemp_data *st, scsi_cmd[12] = lba_high; scsi_cmd[14] = ata_command; - return scsi_execute_req(st->sdev, scsi_cmd, data_dir, - st->smartdata, ATA_SECT_SIZE, NULL, HZ, 5, - NULL); + err = scsi_execute_req(st->sdev, scsi_cmd, data_dir, + st->smartdata, ATA_SECT_SIZE, NULL, HZ, 5, + NULL); + if (err > 0) + err = -EIO; + return err; } static int drivetemp_ata_command(struct drivetemp_data *st, u8 feature, -- 2.53.0