[PATCH] scsi: leapraid: Fix init_cmd_priv error handling

[Dongdong Hao <doubled@leap-io-kernel.com>]

leapraid_init_cmd_priv() ignores the return value of
leapraid_internal_init_cmd_priv() and always returns success. If
dma_pool_alloc() fails, io_tracker->chain remains NULL, but the SCSI
midlayer considers the command successfully initialized.

A subsequent I/O requiring more than LEAPRAID_SGL_INLINE_THRESHOLD
DMA-mapped scatter-gather entries dereferences the NULL chain buffer
while building the chained SGL, causing a kernel crash.

Return the result of leapraid_internal_init_cmd_priv() so that allocation
failures propagate to the SCSI midlayer and abort initialization of the
affected request.

Signed-off-by: Dongdong Hao <doubled@leap-io-kernel.com>
---
 drivers/scsi/leapraid/leapraid_os.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/leapraid/leapraid_os.c b/drivers/scsi/leapraid/leapraid_os.c
index da597eb99377..0f3219c4f438 100644
--- a/drivers/scsi/leapraid/leapraid_os.c
+++ b/drivers/scsi/leapraid/leapraid_os.c
@@ -938,9 +938,8 @@ static int leapraid_init_cmd_priv(struct Scsi_Host *shost,
 	struct leapraid_io_req_tracker *io_tracker;
 
 	io_tracker = scsi_cmd_priv(scmd);
-	leapraid_internal_init_cmd_priv(adapter, io_tracker);
 
-	return 0;
+	return leapraid_internal_init_cmd_priv(adapter, io_tracker);
 }
 
 static int leapraid_exit_cmd_priv(struct Scsi_Host *shost,
-- 
2.25.1