From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.34 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794788370; b=ZsTBslDrt8rKYh8kb/glo2EMaawz3aSN/5DtN+MHNEIJ+GKbXBEHW1fIq76FFIXz2GuY LaZEiXWFGqIH44ZKa0NUd8t7y5BXqxERu8GCORcnVSFuE7paK1CA6sGQni4iWdiQ7vIPl vGxnuFoiDz7MysYUAxK64Nnoq28OP94bT0LEvnXvvLOBfuxExWr4+vs6uXcy9fvDtaQwk uUnvQA/eE3XNeBk6Enc8IfFWyi6gnpBLb5Q4hLb0o+N9I5RCwhVaPZuf/j6PAj/lOiMBv fORo/x2a81eYwlsOy2j2iLtIajTP89Y+Or5B4sVD1r3iep1m1lCFnPhOsX+ZExktNHw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794788370; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:Date:Subject:MIME-Version: Content-Type:Content-Transfer-Encoding:Message-Id:References: In-Reply-To:To:Cc:X-Mailer; bh=nhnHtLieQMdo/OcyKxpaCFLTNFcPVZQRcEluKyBdufo=; b=5VA9loBgml3/W8lYu+4cMpzj5V8e6a2/9C0sSpNF0UcBj9pkE/CLRYpMiQgoYHiYnAH/ cZYJUb9fLw4+IiCHyRUikFdJEoUiX2kcK7reypZ/GcsjtwoLGk/cKacMBGE1pAKFk6HBD PvDICtz2omsoOOQYQ4jfiG32Lji7DiHciA5Ix3kXGvdqAF4xHn0953mP+Ey4+YcalKgaW rsqUlMu+VUx2mj1QXu4ToW3osuRbKpGGscZryBrlTdK2hUVzgYAOAEGVZmLvtLb4bXdx2 wkdMjSUPm8Z0NHgp+Ht/y9/vRIAvdxLXd18u30JfuBoV9aTqdzSM0+weLgAVm5NOslg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=duLJ6bqq; arc=none smtp.remote-ip=91.218.175.34 Received: from mta0.migadu.com (out-34.mta0.migadu.com [91.218.175.34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39854606A331 for ; Mon, 16 Nov 2026 00:19:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 39854606A331 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=duLJ6bqq X-Envelope-To: linux-scsi@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=GE0AmWzzUkTntY8b3KCGh9uV2eo1z/UgLx990fOkw7c=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794788368; v=1; x=1795393168; b=duLJ6bqqAim6rotM3f+vgw8STJSF5W/XrYx0D5tloRenWdzJv9k3zC9oyG0UMcDhDUKt6PQ6 bkRJmrIisLoS75xrTPhUdxtdHePv9tZyrEli9e4v5zYKyq64iuxcoijwEoGUEy4Bx/3LT3m/yy3 yEdraU59edDItWh0dBvvRuhc= X-Envelope-To: linux-scsi@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 9651313902837610; Mon, 16 Nov 2026 00:19:28 +0000 X-Mizu-Trace-ID: 9651313902837610 X-Migadu-Flow: FLOW_OUT From: Qiliang Yuan Date: Sun, 15 Nov 2026 19:18:04 -0500 Subject: [PATCH RFC 11/18] scsi: target: uring: Drop aborted commands that are still queued X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261115-feat-target-core-uring-v1-11-28cdc137eac6@linux.dev> References: <20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev> In-Reply-To: <20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev> To: "Martin K. Petersen" , Shuah Khan , Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Jens Axboe , io-uring@vger.kernel.org, Mike Christie , Bodo Stroesser , Ming Lei , Qiliang Yuan X-Mailer: b4 0.13.0 When a command is aborted, the core waits for the backstore to complete it. A target_core_uring command that no server has fetched only completes when it times out, which delays the abort by up to cmd_time_out. Implement tmr_notify() and complete the aborted commands that are still on a pending list with TASK ABORTED status. Track them through se_cmd->priv, which is set only while a command is pending. Signed-off-by: Qiliang Yuan --- drivers/target/target_core_uring.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/drivers/target/target_core_uring.c b/drivers/target/target_core_uring.c index 0f83bdc55e06a..629419a4c8f46 100644 --- a/drivers/target/target_core_uring.c +++ b/drivers/target/target_core_uring.c @@ -175,6 +175,7 @@ static void tcmur_io_start(struct tcmur_queue *q, struct tcmur_io *io, { lockdep_assert_held(&q->lock); + tcmd->se_cmd->priv = NULL; io->cmd = tcmd; io->owned = true; q->descs[io - q->ios] = tcmd->desc; @@ -207,6 +208,7 @@ static void tcmur_queue_cmd(struct tcmur_dev *udev, struct tcmur_cmd *tcmd) io->ucmd = NULL; tcmur_io_start(q, io, tcmd); } else { + tcmd->se_cmd->priv = tcmd; list_add_tail(&tcmd->node, &q->pending); } spin_unlock(&q->lock); @@ -255,6 +257,31 @@ static sense_reason_t tcmur_execute_rw(struct se_cmd *se_cmd, se_cmd->data_length, sgl, sgl_nents); } +static void tcmur_tmr_notify(struct se_device *dev, enum tcm_tmreq_table tmf, + struct list_head *aborted_cmds) +{ + struct tcmur_dev *udev = TCMUR_DEV(dev); + struct tcmur_cmd *tcmd; + struct tcmur_queue *q; + struct se_cmd *se_cmd; + + /* Drop the aborted commands that no server has picked up yet */ + list_for_each_entry(se_cmd, aborted_cmds, state_list) { + q = tcmur_cmd_queue(udev, se_cmd); + + spin_lock(&q->lock); + tcmd = se_cmd->priv; + if (tcmd) { + se_cmd->priv = NULL; + list_del(&tcmd->node); + } + spin_unlock(&q->lock); + + if (tcmd) + tcmur_cmd_end(tcmd, SAM_STAT_TASK_ABORTED); + } +} + static void tcmur_timeout_work(struct work_struct *work) { struct tcmur_dev *udev = container_of(work, struct tcmur_dev, @@ -278,6 +305,7 @@ static void tcmur_timeout_work(struct work_struct *work) rearm = true; break; } + tcmd->se_cmd->priv = NULL; list_move_tail(&tcmd->node, &expired); } for (j = 0; j < udev->queue_depth; j++) { @@ -920,6 +948,7 @@ static const struct target_backend_ops tcmur_ops = { .destroy_device = tcmur_destroy_device, .free_device = tcmur_free_device, .parse_cdb = tcmur_parse_cdb, + .tmr_notify = tcmur_tmr_notify, .set_configfs_dev_params = tcmur_set_configfs_dev_params, .show_configfs_dev_params = tcmur_show_configfs_dev_params, .get_device_type = sbc_get_device_type, -- 2.43.0