From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.152 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794788326; b=SXPl6EjRXjfXvh0gPICh50A6lJwEZraTCTh5LvBc9Yo6sVbmkTPp4YzShc6v2Tk1HhhB edm3lGgFxLqosZ2JSh9H2GAI39dsgNjhci3tjQoxjFpWsRD7X/izkvhRMf8ihT7ZVBSc0 xTqqbWHoRz/GdVrU7V2IsJTqZEexYQCfGGR3bZ/0LIoWOsYjWffeM1nfBSpcposSOuv73 N82K/gZIt4D0iIF5fvHPkZR/S5dOBNZL/rATyuJ1J9RK91tbdpdqMLAL3nuqd5EX+ib+P oIgSj2HifhePhPq/6YWkS9fZIj+rF+WBPHSVfkzii0OZKfDdyKt5dPNzY19ZNJ748Tw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794788326; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:Date:Subject:MIME-Version: Content-Type:Content-Transfer-Encoding:Message-Id:References: In-Reply-To:To:Cc:X-Mailer; bh=avmRIcRu9EZE8spWIWMDKOK/8vg/KCkRzy/tHk/Ubzk=; b=OKx2tEEKvebMmefSHpVIkpUGKUY/NGnHk0W0ybYzdNPkORt7i2rac0LSSD2J1pw47v9Y hHcPmj6zI4wALe1A3TO5rSFnJ4+GjSxWP0gof4ot4sV7ZohxkSfWLawfakoOdkRsiGKG3 utvhBiK7j3Dse46GCRkA3w4eyCHEPb2vcbtOL0ZXCtMI1oYckhilxS/TnmHkRvyWbd/hK w2Fid5fCJxrh6SE39its2IzsrdgPtyite9plidJos/LKY+3+aFES58MP78qgALDkOUcLu nhrH208VlNEHF3X0TSnSIMNbLqsBiT6H7Bn3Qxw+3Ng8mvyBF5MuVhqcM4xEIOJnUpw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=fv4MMklm; arc=none smtp.remote-ip=95.215.58.152 Received: from mta1.migadu.com (out-152.mta1.migadu.com [95.215.58.152]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D175C606A330 for ; Mon, 16 Nov 2026 00:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D175C606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=fv4MMklm X-Envelope-To: linux-scsi@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=0M2XgL9UYDclhv5Ioofb/hHIFH3uS4AmZa70lUCfTJk=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794788323; v=1; x=1795393123; b=fv4MMklm2Tlng/FD3N9M2rU5Fmegu2HflgvZoYPN3ld3q0ahWRkif5t958REx6iSD3T5Z9Qr w9JFML19iYRDY1+jnEwRJ5DP6OSl9SBA3jv0UV3CQmOA5JpQHoVHcVot06IpCCe2LQzqKgrKkQC KmTbce2SR4+BUM8rriGk/M5Q= X-Envelope-To: linux-scsi@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 556456cca49a77c6; Mon, 16 Nov 2026 00:18:42 +0000 X-Mizu-Trace-ID: 556456cca49a77c6 X-Migadu-Flow: FLOW_OUT From: Qiliang Yuan Date: Sun, 15 Nov 2026 19:17:57 -0500 Subject: [PATCH RFC 04/18] scsi: target: uring: Map the command descriptors into the server X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261115-feat-target-core-uring-v1-4-28cdc137eac6@linux.dev> References: <20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev> In-Reply-To: <20261115-feat-target-core-uring-v1-0-28cdc137eac6@linux.dev> To: "Martin K. Petersen" , Shuah Khan , Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Jens Axboe , io-uring@vger.kernel.org, Mike Christie , Bodo Stroesser , Ming Lei , Qiliang Yuan X-Mailer: b4 0.13.0 Each queue of a target_core_uring device has an array of command descriptors that the kernel fills. The server cannot read the descriptors yet. Let the server mmap() the descriptors of queue q_id at offset q_id * TCMUR_DESC_AREA_SIZE of the character device. Refuse writable mappings, as only the kernel writes descriptors. Signed-off-by: Qiliang Yuan --- drivers/target/target_core_uring.c | 22 +++++++++++++++++++++- include/uapi/linux/target_core_uring.h | 6 +++++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_uring.c b/drivers/target/target_core_uring.c index d1ca4f16e7d0b..904ce2a613618 100644 --- a/drivers/target/target_core_uring.c +++ b/drivers/target/target_core_uring.c @@ -31,7 +31,7 @@ struct tcmur_dev; /** * struct tcmur_queue - One command queue - * @descs: Command descriptors, indexed by tag + * @descs: Command descriptors, indexed by tag and mapped by the server * @udev: Device the queue belongs to */ struct tcmur_queue { @@ -79,6 +79,25 @@ static size_t tcmur_desc_area_size(struct tcmur_dev *udev) return PAGE_ALIGN(udev->queue_depth * sizeof(struct tcmur_io_desc)); } +static int tcmur_ch_mmap(struct file *filp, struct vm_area_struct *vma) +{ + struct tcmur_dev *udev = filp->private_data; + u64 off = (u64)vma->vm_pgoff << PAGE_SHIFT; + u32 rem; + u64 q_id = div_u64_rem(off, TCMUR_DESC_AREA_SIZE, &rem); + + if (rem || q_id >= udev->nr_queues || + vma->vm_end - vma->vm_start != tcmur_desc_area_size(udev)) + return -EINVAL; + + /* Refuse writable mappings, as only the kernel writes descriptors */ + if (vma->vm_flags & VM_WRITE) + return -EPERM; + vm_flags_clear(vma, VM_MAYWRITE); + + return remap_vmalloc_range(vma, udev->queues[q_id].descs, 0); +} + static long tcmur_ch_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { @@ -125,6 +144,7 @@ static const struct file_operations tcmur_ch_fops = { .owner = THIS_MODULE, .open = tcmur_ch_open, .release = tcmur_ch_release, + .mmap = tcmur_ch_mmap, .unlocked_ioctl = tcmur_ch_ioctl, .compat_ioctl = compat_ptr_ioctl, }; diff --git a/include/uapi/linux/target_core_uring.h b/include/uapi/linux/target_core_uring.h index c23e01e7638a2..d2b8ffe40bf7a 100644 --- a/include/uapi/linux/target_core_uring.h +++ b/include/uapi/linux/target_core_uring.h @@ -54,7 +54,8 @@ enum tcmur_io_op { * @data_len: Bytes of data to transfer * @reserved: Zero * - * The descriptors of a queue form an array indexed by tag. + * The descriptors of a queue form an array indexed by tag, which the server + * maps read-only at offset q_id * TCMUR_DESC_AREA_SIZE of the file. */ struct tcmur_io_desc { __u32 op; @@ -65,4 +66,7 @@ struct tcmur_io_desc { __u32 reserved; }; +#define TCMUR_DESC_AREA_SIZE \ + (TCMUR_MAX_QUEUE_DEPTH * sizeof(struct tcmur_io_desc)) + #endif /* _UAPI_LINUX_TARGET_CORE_URING_H */ -- 2.43.0