[PATCH] scsi: ufs: Improve SCSI abort handling

Daejun Park
2021-11-04T22:50:05Z

Hi Bart,

>diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
>index 3b4a714e2f68..d8a59258b1dc 100644
>--- a/drivers/scsi/ufs/ufshcd.c
>+++ b/drivers/scsi/ufs/ufshcd.c
>@@ -7069,6 +7069,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> goto release;
> }
>
>+ lrbp->cmd = NULL;
> err = SUCCESS;
>
> release:

I found similar code in the ufshcd_err_handler(). I think the following
patch will required to fix another warning.

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index f5ba8f953b87..cce9abc6b879 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6190,6 +6190,7 @@ static void ufshcd_err_handler(struct work_struct *work)
}
dev_err(hba->dev, "Aborted tag %d / CDB %#02x\n", tag,
hba->lrb[tag].cmd ? hba->lrb[tag].cmd->cmnd[0] : -1);
+ hba->lrb[tag].cmd = NULL;
}

/* Clear pending task management requests */

Thanks,
Daejun