From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 004.mia.mailroute.net (004.mia.mailroute.net [199.89.3.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E992264BA; Mon, 15 Sep 2025 21:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.3.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757970943; cv=none; b=jBXfh54Ycc830QIkGitJXQcNBy48QsKviC6epb95EK6UXFJcDVKt2HqsERp1c0koUD87xrR7ZkHRzPF/08m7/Q2HgSCBQhuBCpCqZqGEObYeAEItb2VVB5FeCat2k6SGWa7oJ5tsINa0zaEnu7iYELlQL77HWiA/7owc3/eC7e0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757970943; c=relaxed/simple; bh=qDQ1tohA3HbprM53H/J9GwJb+U8i9aiiYu1LQIePXJ8=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=AFiLvUp3kA2paqFkKNWW6sYGe738sdbIwlDR07ksnixDjLIL4InmWFzv55AC0tW9B8M0cAx3dQl0WO8+XfdS55O4cT+v//sKZve43VTlWgNRUfSe9UJaIuUOn1awjTfs0BaYowe9/JfrokWyR3FR5G+nbmPr09wlkVx7N4ig/ZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=SXhgUes3; arc=none smtp.client-ip=199.89.3.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="SXhgUes3" Received: from localhost (localhost [127.0.0.1]) by 004.mia.mailroute.net (Postfix) with ESMTP id 4cQd9S58kMzm0ySc; Mon, 15 Sep 2025 21:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1757970938; x=1760562939; bh=H1E7sIGYz3CBolGTyUVlAtB+ G56TZ/puB1NJ9ZnovnQ=; b=SXhgUes3abq4n5n914M/cCg+90XBHoeJ6VIlBlso 3+WI0/Mm/Svmep4kDoTZ8jKORakGi/9QivfSTNHMfGH8JV80kzyxmcGAcEYgTjch OSnc7Rm8bbLNov28Kl1f04N4j7K50S4s9Z59klcdyOrh59G2BbJsWx4RiTJMK8yT yTvY1TrB3n/pHACvDrjoD0zuHQMFXUla9b9JjZrWv8BoJG4ZqqcH3NyT0oLFq2XM 5S5hv90T/40eIc8LJKzkgd7RbYWVyLPUuDKtaKln2AV5uXutFDnGCsf1DvhdOvZy ZwD95ECZ8ox23Dch+WpOiQ3marlDzWj9hcK2GbDZFH0LNg== X-Virus-Scanned: by MailRoute Received: from 004.mia.mailroute.net ([127.0.0.1]) by localhost (004.mia [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id ViE_q4oKjZis; Mon, 15 Sep 2025 21:15:38 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 004.mia.mailroute.net (Postfix) with ESMTPSA id 4cQd9B5hZLzm1743; Mon, 15 Sep 2025 21:15:26 +0000 (UTC) Message-ID: <227f36d8-ca89-486f-b39b-c971e08e20c4@acm.org> Date: Mon, 15 Sep 2025 14:15:25 -0700 Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] block/genhd: add sysfs knobs for the device frequency PM QoS To: Wang Jianzheng , Jens Axboe , Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , "Rafael J. Wysocki" , Peter Wang , Bean Huo , "Bao D. Nguyen" , Adrian Hunter , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org References: <20250914114549.650671-1-wangjianzheng@vivo.com> <20250914114549.650671-2-wangjianzheng@vivo.com> Content-Language: en-US From: Bart Van Assche In-Reply-To: <20250914114549.650671-2-wangjianzheng@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/14/25 4:45 AM, Wang Jianzheng wrote: > block/genhd.c | 23 +++++++++++++++++++++++ > include/linux/blkdev.h | 2 ++ If a new sysfs attribute is added then an entry must be added in Documentation/ABI/ that explains the purpose of the new attribute and also how to use it. > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -213,6 +213,8 @@ struct gendisk { > u64 diskseq; > blk_mode_t open_mode; > > + int dev_freq_timeout; The name `dev_freq_timeout` is not sufficient to guess the meaning of the attribute. Please add a comment. Thanks, Bart.