From: Martin Steigerwald <martin@lichtvoll.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <jthumshirn@suse.de>,
Tejun Heo <tj@kernel.org>,
Oleksandr Natalenko <oleksandr@natalenko.name>,
stable@vger.kernel.org
Subject: Re: [PATCH] Change synchronize_rcu() in scsi_device_quiesce() into synchronize_sched()
Date: Mon, 19 Mar 2018 10:02:18 +0100 [thread overview]
Message-ID: <23066547.s73LNzlmaa@merkaba> (raw)
In-Reply-To: <c95b659b-164e-48f7-2033-30fb8f66462f@wdc.com>
Hi Bart.
Bart Van Assche - 16.03.18, 22:51:
> On 03/16/18 14:42, Martin Steigerwald wrote:
> > What is this one about?
> >
> > Fix for the regression I (and others?) reported?¹
> >
> > [1] [Bug 199077] [Possible REGRESSION, 4.16-rc4] Error updating SMART data
> > during runtime and boot failures with blk_mq_terminate_expired in
> > backtrace
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=199077
[…]
> This patch is a fix for the fix for the bug that you and others had
> reported. See also "I/O hangs after resuming from suspend-to-ram"
> (https://marc.info/?l=linux-block&m=150340235201348).
>
> This patch fixes an API violation. For those users for which suspend and
> resume works fine with commit 3a0a529971ec applied it should still work
> fine with this patch applied since this patch may cause
> scsi_device_quiesce() to wait longer.
Okay, so if I understand you correctly, this is not related to the regression
I mentioned above.
Testing anyway.
Thanks,
--
Martin
next prev parent reply other threads:[~2018-03-19 9:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 17:35 [PATCH] Change synchronize_rcu() in scsi_device_quiesce() into synchronize_sched() Bart Van Assche
2018-03-16 21:42 ` Martin Steigerwald
2018-03-16 21:51 ` Bart Van Assche
2018-03-19 9:02 ` Martin Steigerwald [this message]
2018-03-19 14:31 ` Tejun Heo
2018-03-19 15:16 ` Bart Van Assche
2018-03-19 15:21 ` tj
2018-03-19 16:18 ` Bart Van Assche
2018-03-19 16:29 ` tj
2018-03-19 16:57 ` Bart Van Assche
2018-03-19 17:02 ` tj
2018-03-19 20:19 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23066547.s73LNzlmaa@merkaba \
--to=martin@lichtvoll.de \
--cc=bart.vanassche@wdc.com \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox