Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "bvanassche@acm.org" <bvanassche@acm.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "vamshigajjela@google.com" <vamshigajjela@google.com>,
	"alok.a.tiwari@oracle.com" <alok.a.tiwari@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"chenyuan0y@gmail.com" <chenyuan0y@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	"ping.gao@samsung.com" <ping.gao@samsung.com>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v2 1/2] ufs: core: Introduce ufshcd_mcq_poll_n_cqe_lock()
Date: Thu, 14 May 2026 07:34:43 +0000	[thread overview]
Message-ID: <23d57dd91882a3014c0d97a7b08b81117ade5b72.camel@mediatek.com> (raw)
In-Reply-To: <d81c6987-6f76-4391-a713-96bbde4efc8d@acm.org>

On Wed, 2026-05-13 at 12:26 -0700, Bart Van Assche wrote:
> On 5/12/26 11:50 PM, Peter Wang (王信友) wrote:
> > May I ask if you have any plans to continue upstreaming this patch
> > in the future?
> 
> Hi Peter,
> 
> After I posted this patch series I learned that even processing a
> single
> completion can cause interrupts to be disabled for too long. I think
> the
> root cause is in F2FS (f2fs_write_end_io()). I have reported this to
> the
> F2FS team and I'm waiting for their feedback. After F2FS has been
> improved I will repeat my measurements and reduce the number of
> completions processed in interrupt context if that is still
> necessary.
> 
> Thanks,
> 
> Bart.


Hi Bart,

I'm sure we're facing the same issue. F2FS hooks a heavy function
in the UFS ISR callback. However, the UFS ISR still cannot acquire
the spinlock and executes an unknown task that disables IRQs, 
the duration of which is controlled by F2FS. 
I plan to fine-tune this by posting another patch.

Thanks.
Peter




  reply	other threads:[~2026-05-14  7:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02 17:14 [PATCH v2 0/2] ufs-qcom: Reduce interrupt latency Bart Van Assche
2026-04-02 17:14 ` [PATCH v2 1/2] ufs: core: Introduce ufshcd_mcq_poll_n_cqe_lock() Bart Van Assche
2026-05-13  6:50   ` Peter Wang (王信友)
2026-05-13 19:26     ` Bart Van Assche
2026-05-14  7:34       ` Peter Wang (王信友) [this message]
2026-05-14 16:20         ` Bart Van Assche
2026-04-02 17:14 ` [PATCH v2 2/2] ufs: qcom: Reduce interrupt latency Bart Van Assche
2026-04-30 16:23   ` Martin K. Petersen
2026-04-30 16:21 ` [PATCH v2 0/2] ufs-qcom: " Martin K. Petersen
2026-04-30 17:21   ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23d57dd91882a3014c0d97a7b08b81117ade5b72.camel@mediatek.com \
    --to=peter.wang@mediatek.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alok.a.tiwari@oracle.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bvanassche@acm.org \
    --cc=chenyuan0y@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=ping.gao@samsung.com \
    --cc=vamshigajjela@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox