From: Bart Van Assche <bvanassche@acm.org>
To: Abinash Singh <abinashsinghlalotra@gmail.com>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/2] scsi: sd: Fix build warning in sd_revalidate_disk()
Date: Tue, 19 Aug 2025 12:26:23 -0700 [thread overview]
Message-ID: <240eec29-860d-437c-8e46-9c7af3e4a0fc@acm.org> (raw)
In-Reply-To: <20250816205329.404116-2-abinashsinghlalotra@gmail.com>
On 8/16/25 1:53 PM, Abinash Singh wrote:
> + kfree(lim);
> + kfree(buffer);
The traditional order for kfree() statements is the opposite order of
the corresponding kmalloc() calls. With or without this change:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2025-08-19 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 20:53 [PATCH v7 0/2] scsi: sd: Fix build warning in sd_revalidate_disk() Abinash Singh
2025-08-16 20:53 ` [PATCH v7 1/2] " Abinash Singh
2025-08-19 19:26 ` Bart Van Assche [this message]
2025-08-16 20:53 ` [PATCH v7 2/2] scsi: sd: make sd_revalidate_disk() return void Abinash Singh
2025-08-19 19:24 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=240eec29-860d-437c-8e46-9c7af3e4a0fc@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abinashsinghlalotra@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).