From: Bean Huo <huobean@gmail.com>
To: peter.wang@mediatek.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, avri.altman@wdc.com,
alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
cc.chou@mediatek.com, chaotian.jing@mediatek.com,
jiajie.hao@mediatek.com, yi-fan.peng@mediatek.com,
qilin.tan@mediatek.com, lin.gui@mediatek.com,
tun-yu.yu@mediatek.com, eddie.huang@mediatek.com,
naomi.chu@mediatek.com, ed.tsai@mediatek.com,
bvanassche@acm.org
Subject: Re: [PATCH v3] ufs: core: add hba parameter to trace events
Date: Sun, 16 Feb 2025 15:15:33 +0100 [thread overview]
Message-ID: <2420c932bd2443b3c924c02a1375ae63bed8ab6e.camel@gmail.com> (raw)
In-Reply-To: <20250214083026.1177880-1-peter.wang@mediatek.com>
On Fri, 2025-02-14 at 16:29 +0800, peter.wang@mediatek.com wrote:
> From: Peter Wang <peter.wang@mediatek.com>
>
> Included the ufs_hba structure as a parameter in various trace events
> to provide more context and improve debugging capabilities.
From the patch commit message, it is no clear how you can use this
change to get more infor and debug, since the content of the ftrace
output is the same after this change. Because the device name
(dev_name) is still being printed, but now it is derived dynamically
from hba->dev instead of being stored as a string in the trace event.
I assume you mean to let bpf get more information from hba:
strust ufs hba *hba = ctx->hba;
If my assumption is correct, this purpose and intent should be
prominently highlighted in patch commit message.
Kind regards,
Bean
next prev parent reply other threads:[~2025-02-16 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 8:29 [PATCH v3] ufs: core: add hba parameter to trace events peter.wang
2025-02-14 17:12 ` Bart Van Assche
2025-02-16 14:15 ` Bean Huo [this message]
2025-02-17 5:32 ` Peter Wang (王信友)
2025-02-19 1:55 ` Martin K. Petersen
2025-02-25 0:32 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2420c932bd2443b3c924c02a1375ae63bed8ab6e.camel@gmail.com \
--to=huobean@gmail.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=tun-yu.yu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
--cc=yi-fan.peng@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox