From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: John Garry <john.garry@huawei.com>,
Christoph Hellwig <hch@infradead.org>
Cc: "Ewan D. Milne" <emilne@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Doug Gilbert <dgilbert@interlog.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
james.smart@broadcom.com
Subject: Re: [PATCH 1/4] scsi: core: constify pointer to scsi_host_template
Date: Mon, 25 Apr 2022 11:22:48 +0200 [thread overview]
Message-ID: <24bfb681-faec-3567-3089-9cd5ee182710@linaro.org> (raw)
In-Reply-To: <d09faf74-a52e-8d93-cf26-08b43b12c564@huawei.com>
On 25/04/2022 10:58, John Garry wrote:
> On 20/04/2022 08:03, Christoph Hellwig wrote:
>>> The standard flow is:
>>>
>>> shost = scsi_host_alloc(sht, )
>>>
>>> // modify shost, like
>>> shost->cmd_per_lun = 5;
>>>
>>> scsi_add_host(shost)
>>>
>>> Is there some reason for which those two drivers can't follow that?
>> I think they should. Method tables should not be mutable data.
>> .
>
> Hi Krzysztof,
>
> Do you have any interest in going further with your work and trying to
> change all SCSI driver instances of scsi_host_template to be const? I am
> not sure if it has been attempted before...
I can work on this, but what about the SCSI core modifying the template?
For example scsi_proc_hostdir_rm(): 'present' and 'proc_dir' members.
Where should they be stored? Should they be moved to the Scsi_Host?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-25 9:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 10:30 [PATCH 1/4] scsi: core: constify pointer to scsi_host_template Krzysztof Kozlowski
2022-04-08 10:30 ` [PATCH 2/4] scsi: core: fix white-spaces Krzysztof Kozlowski
2022-05-04 8:47 ` Krzysztof Kozlowski
2022-04-08 10:30 ` [PATCH 3/4] scsi: ufs: ufshcd-pltfrm: constify pointed data Krzysztof Kozlowski
2022-04-08 10:30 ` [PATCH 4/4] scsi: ufs: ufshcd: " Krzysztof Kozlowski
2022-04-08 14:35 ` Bart Van Assche
2022-04-08 12:14 ` [PATCH 1/4] scsi: core: constify pointer to scsi_host_template John Garry
2022-04-08 12:32 ` Krzysztof Kozlowski
2022-04-08 12:57 ` John Garry
2022-04-08 19:31 ` Ewan D. Milne
2022-04-12 7:57 ` John Garry
2022-04-20 7:03 ` Christoph Hellwig
2022-04-25 8:58 ` John Garry
2022-04-25 9:22 ` Krzysztof Kozlowski [this message]
2022-04-25 13:04 ` John Garry
2022-04-26 1:16 ` Bart Van Assche
2022-04-26 1:54 ` Douglas Gilbert
2022-04-26 4:13 ` Bart Van Assche
2022-04-27 1:47 ` Douglas Gilbert
2022-05-06 16:42 ` Krzysztof Kozlowski
2022-05-09 11:28 ` John Garry
2022-05-09 13:20 ` Krzysztof Kozlowski
2022-05-09 14:50 ` John Garry
2022-05-11 8:31 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24bfb681-faec-3567-3089-9cd5ee182710@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=dgilbert@interlog.com \
--cc=emilne@redhat.com \
--cc=hch@infradead.org \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox