Re: [PATCH v2 3/5] ata: Add APM X-Gene SATA driver

Loc Ho
2013-11-12T22:39:50Z

Hi Arnd,

I looked at the PHY generic framework and come across this statement
below. Our SATA PHY is embedded into the SoC. Should I ignore this
statement below and implement the PHY driver using this framework?

+This framework will be of use only to devices that use external PHY (PHY
+functionality is not embedded within the controller).

-Loc

On Tue, Nov 12, 2013 at 5:11 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 12 November 2013, Loc Ho wrote:
>> Hi Arnd/Olof,
>>
>> I looked over the phy code for USB and NET. There isn't such PHY
>> infrastructure for SATA from what I can tell. It seems like I will
>> need to put this all together. I am thinking about porting the USB
>> version over (with changes for SATA) and put it under
>> "./drivers/ata/phy". Any suggestion?
>
> Please have a look at the patches under the subject "Generic PHY Framework"
> posted by Kishon Vijay Abraham. I thought they would have made it in
> by now, but I have not followed the recent kernels closely since I am
> on parental leave at the moment.
>
> IIRC they should unify USB, SATA and other PHY codes, but not network.
>
> Arnd