From: Jens Axboe <axboe@kernel.dk>
To: Guenter Roeck <linux@roeck-us.net>, Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, nbd@other.debian.org,
ceph-devel@vger.kernel.org, virtualization@lists.linux.dev,
linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] block: force noio scope in blk_mq_freeze_queue
Date: Mon, 3 Feb 2025 08:12:04 -0700 [thread overview]
Message-ID: <262032e2-a248-40aa-b5bd-deccc6c405ca@kernel.dk> (raw)
In-Reply-To: <2273ad20-ed56-429c-a6ef-ffdb3196782b@roeck-us.net>
On 2/3/25 8:09 AM, Guenter Roeck wrote:
> On Fri, Jan 31, 2025 at 01:03:47PM +0100, Christoph Hellwig wrote:
>> When block drivers or the core block code perform allocations with a
>> frozen queue, this could try to recurse into the block device to
>> reclaim memory and deadlock. Thus all allocations done by a process
>> that froze a queue need to be done without __GFP_IO and __GFP_FS.
>> Instead of tying to track all of them down, force a noio scope as
>> part of freezing the queue.
>>
>> Note that nvme is a bit of a mess here due to the non-owner freezes,
>> and they will be addressed separately.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> All sparc64 builds fail with this patch in the tree.
Yep, Stephen reported the same yesterday. The patch is queued up,
will most likely just send it out separately.
--
Jens Axboe
prev parent reply other threads:[~2025-02-03 15:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 12:03 annotate noio context v2 Christoph Hellwig
2025-01-31 12:03 ` [PATCH] block: force noio scope in blk_mq_freeze_queue Christoph Hellwig
2025-01-31 15:13 ` Jens Axboe
2025-02-03 15:09 ` Guenter Roeck
2025-02-03 15:12 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=262032e2-a248-40aa-b5bd-deccc6c405ca@kernel.dk \
--to=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ming.lei@redhat.com \
--cc=nbd@other.debian.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox