From: Hannes Reinecke <hare@suse.de>
To: mwilck@suse.com,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>, Ming Lei <ming.lei@redhat.com>,
Bart Van Assche <bvanassche@acm.org>
Cc: James Bottomley <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH v4 5/6] scsi: don't wait for quiesce in scsi_device_block()
Date: Mon, 12 Jun 2023 17:42:34 +0200 [thread overview]
Message-ID: <26ad0240-0f41-e5b8-412d-972c2f9ac63f@suse.de> (raw)
In-Reply-To: <20230612145638.16999-6-mwilck@suse.com>
On 6/12/23 16:56, mwilck@suse.com wrote:
> From: Martin Wilck <mwilck@suse.com>
>
> scsi_device_block() is only called from scsi_target_block(), which
> calls it repeatedly for every child device. For targets with many devices,
> waiting for every queue to quiesce may cause a substantial delay
> (we measured more than 100s delay for blocking a FC rport with 2048 LUNs).
>
> Just call blk_mq_wait_quiesce_done() once from scsi_target_block() after
> stopping all queues.
>
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
> drivers/scsi/scsi_lib.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman
next prev parent reply other threads:[~2023-06-12 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230612145638.16999-1-mwilck@suse.com>
[not found] ` <20230612145638.16999-4-mwilck@suse.com>
2023-06-12 15:35 ` [PATCH v4 3/6] scsi: merge scsi_internal_device_block() and device_block() Hannes Reinecke
[not found] ` <20230612145638.16999-5-mwilck@suse.com>
2023-06-12 15:42 ` [PATCH v4 4/6] scsi: don't wait for quiesce in scsi_stop_queue() Hannes Reinecke
[not found] ` <20230612145638.16999-6-mwilck@suse.com>
2023-06-12 15:42 ` Hannes Reinecke [this message]
[not found] ` <20230612145638.16999-7-mwilck@suse.com>
2023-06-12 15:44 ` [PATCH v4 6/6] scsi: replace scsi_target_block() by scsi_block_targets() Hannes Reinecke
2023-06-12 15:03 [PATCH v4 0/6] scsi: fixes for targets with many LUNs, and scsi_target_block rework mwilck
2023-06-12 15:03 ` [PATCH v4 5/6] scsi: don't wait for quiesce in scsi_device_block() mwilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26ad0240-0f41-e5b8-412d-972c2f9ac63f@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox