Re: [PATCH v2 2/2] scsi: core: Eliminate scsi_log_{reserve,release}_buffer()

[Bart Van Assche <bvanassche@acm.org>]

On 9/10/26 3:45 AM, Hannes Reinecke wrote:
> But in removing scsi_log we're back to square one, namely that we
> cannot assemble a single line of logging with several calls
> (eg as required when dumping a hex buffer or a SCSI command).

This patch uses %*ph to dump hex buffers. No temporary buffers are
required to dump a hex buffer. The temporary buffers introduced by
this patch are as follows:

+	char opcode_name[64];
+	char sense_hdr[64];
+	char extd_sense[96];
+	char mlret_buf[32];
+	char hb_buf[40];

Personally I prefer the introduction of these temporary buffers rather
than making every sdev_prefix_printk() call perform a fixed-size
GFP_ATOMIC allocation. This patch eliminates the risk of log line
suppression because of GFP_ATOMIC memory allocation failure and also
eliminates the 128 byte line limit length.

Thanks,

Bart.