From: Jens Axboe <axboe@kernel.dk>
To: John Garry <john.garry@huawei.com>, linux-block@vger.kernel.org
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCHSET v3] Batched completions
Date: Wed, 20 Oct 2021 08:02:17 -0600 [thread overview]
Message-ID: <27be55bd-2a94-2c11-bf9f-934cefb9dbbe@kernel.dk> (raw)
In-Reply-To: <b47e9ae3-52e0-8cfa-9dcb-bfd46ad4c46d@huawei.com>
On 10/20/21 5:14 AM, John Garry wrote:
> On 17/10/2021 03:06, Jens Axboe wrote:
>> Hi,
>
> +linux-scsi
>
>>
>> We now do decent batching of allocations for submit, but we still
>> complete requests individually. This costs a lot of CPU cycles.
>>
>> This patchset adds support for collecting requests for completion,
>> and then completing them as a batch. This includes things like freeing
>> a batch of tags.
>>
>> This version is looking pretty good to me now, and should be ready
>> for 5.16.
>
> Just wondering if anyone was looking at supporting this for SCSI
> midlayer? I was thinking about looking at it...
Since it's pretty new, don't think anyone has looked at that yet.
I just did the nvme case, for both submit and complete batching.
But the code is generic and would plug into anything.
--
Jens Axboe
prev parent reply other threads:[~2021-10-20 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211017020623.77815-1-axboe@kernel.dk>
2021-10-20 11:14 ` [PATCHSET v3] Batched completions John Garry
2021-10-20 14:02 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27be55bd-2a94-2c11-bf9f-934cefb9dbbe@kernel.dk \
--to=axboe@kernel.dk \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox