* Re: [PATCHSET v3] Batched completions [not found] <20211017020623.77815-1-axboe@kernel.dk> @ 2021-10-20 11:14 ` John Garry 2021-10-20 14:02 ` Jens Axboe 0 siblings, 1 reply; 2+ messages in thread From: John Garry @ 2021-10-20 11:14 UTC (permalink / raw) To: Jens Axboe, linux-block; +Cc: linux-scsi@vger.kernel.org On 17/10/2021 03:06, Jens Axboe wrote: > Hi, +linux-scsi > > We now do decent batching of allocations for submit, but we still > complete requests individually. This costs a lot of CPU cycles. > > This patchset adds support for collecting requests for completion, > and then completing them as a batch. This includes things like freeing > a batch of tags. > > This version is looking pretty good to me now, and should be ready > for 5.16. Just wondering if anyone was looking at supporting this for SCSI midlayer? I was thinking about looking at it... > > Changes since v2: > - Get rid of dev_id > - Get rid of mq_ops->complete_batch > - Drop now unnecessary ib->complete setting in blk_poll() > - Drop one sbitmap patch that was questionnable > - Rename io_batch to io_comp_batch > - Track need_timestamp on per-iob basis instead of for each request > - Drop elevator support for batching, cleaner without > - Make the batched driver addition simpler > - Unify nvme polled/irq handling > - Drop io_uring file checking, no longer neededd > - Cleanup io_uring completion side > ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCHSET v3] Batched completions 2021-10-20 11:14 ` [PATCHSET v3] Batched completions John Garry @ 2021-10-20 14:02 ` Jens Axboe 0 siblings, 0 replies; 2+ messages in thread From: Jens Axboe @ 2021-10-20 14:02 UTC (permalink / raw) To: John Garry, linux-block; +Cc: linux-scsi@vger.kernel.org On 10/20/21 5:14 AM, John Garry wrote: > On 17/10/2021 03:06, Jens Axboe wrote: >> Hi, > > +linux-scsi > >> >> We now do decent batching of allocations for submit, but we still >> complete requests individually. This costs a lot of CPU cycles. >> >> This patchset adds support for collecting requests for completion, >> and then completing them as a batch. This includes things like freeing >> a batch of tags. >> >> This version is looking pretty good to me now, and should be ready >> for 5.16. > > Just wondering if anyone was looking at supporting this for SCSI > midlayer? I was thinking about looking at it... Since it's pretty new, don't think anyone has looked at that yet. I just did the nvme case, for both submit and complete batching. But the code is generic and would plug into anything. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-20 14:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211017020623.77815-1-axboe@kernel.dk>
2021-10-20 11:14 ` [PATCHSET v3] Batched completions John Garry
2021-10-20 14:02 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox