From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.garry@linux.dev>,
James.Bottomley@HansenPartnership.com, mkp@kernel.org
Cc: linux-scsi@vger.kernel.org, hare@suse.de
Subject: Re: [PATCH RFC] scsi: core: Clear cmd->flags for terminal queuing error
Date: Wed, 9 Sep 2026 10:55:13 -0700 [thread overview]
Message-ID: <27d34a00-8bee-4cc7-8d2e-41166affcd9c@acm.org> (raw)
In-Reply-To: <60306ea1-f186-4f63-b29b-aebdc0433945@linux.dev>
On 9/9/26 9:49 AM, John Garry wrote:
> Yes, logically this looks the same. However does scsi_cleanup_rq() need
> the unsetting of RQF_DONTPREP at ***, below. I suppose that it is not
> doing any harm if the req is going to end.
It's not necessary in the scsi_queue_rq() code path that we are
discussing but it improves consistency because clearing RQF_DONTPREP
reflects that the scsi_mq_uninit_cmd() call undid the changes made
by the code that sets RQF_DONTPREP.
Thanks,
Bart.
prev parent reply other threads:[~2026-09-09 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 12:08 [PATCH RFC] scsi: core: Clear cmd->flags for terminal queuing error John Garry
2026-09-09 16:32 ` Bart Van Assche
2026-09-09 16:49 ` John Garry
2026-09-09 17:55 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27d34a00-8bee-4cc7-8d2e-41166affcd9c@acm.org \
--to=bvanassche@acm.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.de \
--cc=john.garry@linux.dev \
--cc=linux-scsi@vger.kernel.org \
--cc=mkp@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox