From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A30C7C001B0 for ; Tue, 15 Aug 2023 09:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236132AbjHOJhv (ORCPT ); Tue, 15 Aug 2023 05:37:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236230AbjHOJhs (ORCPT ); Tue, 15 Aug 2023 05:37:48 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43E4C19A6; Tue, 15 Aug 2023 02:37:47 -0700 (PDT) Received: from canpemm100004.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RQ5gj6qvBztS6c; Tue, 15 Aug 2023 17:34:09 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm100004.china.huawei.com (7.192.105.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 15 Aug 2023 17:37:45 +0800 Subject: Re: [PATCH 10/10] scsi: libsas: Delete sas_ata_task.retry_count To: John Garry , , , , , CC: , , References: <20230814141022.36875-1-john.g.garry@oracle.com> <20230814141022.36875-11-john.g.garry@oracle.com> From: Jason Yan Message-ID: <27eeb032-c22f-127f-e54a-58d8e48581de@huawei.com> Date: Tue, 15 Aug 2023 17:37:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20230814141022.36875-11-john.g.garry@oracle.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm100004.china.huawei.com (7.192.105.92) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2023/8/14 22:10, John Garry wrote: > Since libsas was introduced in commit 2908d778ab3e ("[SCSI] aic94xx: new > driver"), sas_ata_task.retry_count is never set, so delete it and the > reference in asd_build_ata_ascb(). > > Signed-off-by: John Garry > --- > drivers/scsi/aic94xx/aic94xx_task.c | 2 +- > include/scsi/libsas.h | 2 -- > 2 files changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Jason Yan