From: James Smart <james.smart@broadcom.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org,
Martin George <martin.george@netapp.com>,
Daniel Wagner <daniel.wagner@suse.com>,
Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] lpfc: remove left-over BUILD_NVME defines
Date: Thu, 17 Oct 2019 09:52:08 -0700 [thread overview]
Message-ID: <28a3dd70-9507-3838-6470-a3069bf2880d@broadcom.com> (raw)
In-Reply-To: <20191017150019.75769-1-hare@suse.de>
On 10/17/2019 8:00 AM, Hannes Reinecke wrote:
> The BUILD_NVME define never got defined anywhere, causing
> NVMe commands to be treated as SCSI commands when freeing
> the buffers.
> This was causing a stuck discovery and a horrible crash
> in lpfc_set_rrq_active() later on.
>
> Fixes: c00f62e6c546 ("scsi: lpfc: Merge per-protocol WQ/CQ pairs into single per-cpu pair")
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 2 --
> drivers/scsi/lpfc/lpfc_scsi.c | 2 --
> 2 files changed, 4 deletions(-)
>
>
Yep. Thanks.
Reviewed-by: James Smart <james.smart@broadcom.com>
-- james
next prev parent reply other threads:[~2019-10-17 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 15:00 [PATCH] lpfc: remove left-over BUILD_NVME defines Hannes Reinecke
2019-10-17 16:52 ` James Smart [this message]
2019-10-18 2:01 ` Martin K. Petersen
2019-10-18 16:36 ` James Smart
2019-10-18 21:22 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28a3dd70-9507-3838-6470-a3069bf2880d@broadcom.com \
--to=james.smart@broadcom.com \
--cc=daniel.wagner@suse.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.george@netapp.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox