Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: martin.petersen@oracle.com, james.bottomley@hansenpartnership.com
Cc: linux-scsi@vger.kernel.org, bvanassche@acm.org, jiangjianjun3@huawei.com
Subject: Re: [PATCH RFT 0/6] scsi_debug: fake timeout handling improvements
Date: Mon, 1 Dec 2025 15:32:46 +0000	[thread overview]
Message-ID: <28ec2d8d-0da4-4ca9-9a8b-3c2c42d6de9c@oracle.com> (raw)
In-Reply-To: <20251113133645.2898748-1-john.g.garry@oracle.com>

On 13/11/2025 13:36, John Garry wrote:
> This series includes improvements to fake timeout handling.
> 
> Specifically, when we try to abort a scsi_cmnd which has fake timeout,
> we check the deferral type, but this would not be set properly. In
> addition, we need special handling for fake timeout in the abort handler
> to ensure that we don't get confused with any other deferral type.
> 

Hi Martin,

Can you please consider picking up the first 3 patches in this series? I 
am awaiting feedback from JiangJianJun for the rest.

Thanks

> I am setting as RTF as I want to test more. I also would like
> JiangJianJun <jiangjianjun3@huawei.com> to see if it can solve the
> problem reported at https://lore.kernel.org/linux-scsi/4efb45b3-455a-44e8-83fa-e64ca8b9192a@oracle.com/T/#m2092593f3bc4b5fdde3f77376b65c10ab7bd605c
> 
> Finally some tidy-ups are included, which are not RFT.
> 
> John Garry (6):
>    scsi: scsi_debug: Stop printing extra function name in debug logs
>    scsi: scsi_debug: Stop using READ/WRITE_ONCE() when accessing
>      sdebug_defer.defer_t
>    scsi: scsi_debug: Drop NULL scsi_cmnd check in sdebug_q_cmd_complete()
>    scsi: scsi_debug: Call sdebug_q_cmd_complete() from
>      sdebug_blk_mq_poll_iter()
>    scsi: scsi_debug: Clear sd_dp->defer_t in sdebug_q_cmd_complete()
>    scsi: scsi_debug: Add special abort handling for fake timeout
> 
>   drivers/scsi/scsi_debug.c | 163 +++++++++++++++++++-------------------
>   1 file changed, 83 insertions(+), 80 deletions(-)
> 


  parent reply	other threads:[~2025-12-01 15:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 13:36 [PATCH RFT 0/6] scsi_debug: fake timeout handling improvements John Garry
2025-11-13 13:36 ` [PATCH 1/6] scsi: scsi_debug: Stop printing extra function name in debug logs John Garry
2025-11-13 13:36 ` [PATCH 2/6] scsi: scsi_debug: Stop using READ/WRITE_ONCE() when accessing sdebug_defer.defer_t John Garry
2025-11-13 17:45   ` Bart Van Assche
2025-11-14  9:02     ` John Garry
2025-11-14 16:27       ` Bart Van Assche
2025-11-13 13:36 ` [PATCH 3/6] scsi: scsi_debug: Drop NULL scsi_cmnd check in sdebug_q_cmd_complete() John Garry
2025-11-13 17:46   ` Bart Van Assche
2025-11-14  9:02     ` John Garry
2025-11-13 13:36 ` [PATCH RFT 4/6] scsi: scsi_debug: Call sdebug_q_cmd_complete() from sdebug_blk_mq_poll_iter() John Garry
2025-11-13 13:36 ` [PATCH RFT 5/6] scsi: scsi_debug: Clear sd_dp->defer_t in sdebug_q_cmd_complete() John Garry
2025-11-13 13:36 ` [PATCH RFT 6/6] scsi: scsi_debug: Add special abort handling for fake timeout John Garry
2025-12-01 15:32 ` John Garry [this message]
2025-12-17  2:48   ` [PATCH RFT 0/6] scsi_debug: fake timeout handling improvements Martin K. Petersen
2025-12-17 12:48     ` John Garry
2026-04-16  2:30       ` JiangJianJun
2026-04-16  9:12         ` John Garry
2026-01-04 21:43 ` (subset) " Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28ec2d8d-0da4-4ca9-9a8b-3c2c42d6de9c@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=bvanassche@acm.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jiangjianjun3@huawei.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox