Re: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion

Christoph Hellwig
2005-07-13T14:37:57Z

> In general, this construct:
>
> > > -#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,6))
> > > -static int inline scsi_device_online(struct scsi_device *sdev)
> > > -{
> > > - return sdev->online;
> > > -}
> > > -#endif
>
> is better tested as:
>
> #ifndef scsi_device_inline
> static int inline scsi_device_online(struct scsi_device *sdev)
> {
> return sdev->online;
> }
> #endif

Even better fusion should stop using this function because doing so
is broken.. We tried that long ago but it got stuck somewhere.