From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: Luben Tuikov <luben_tuikov@adaptec.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices)
Date: Fri, 9 Sep 2005 12:59:08 -0700 [thread overview]
Message-ID: <29495f1d05090912591d55be5f@mail.gmail.com> (raw)
In-Reply-To: <4321E51F.8040906@adaptec.com>
On 9/9/05, Luben Tuikov <luben_tuikov@adaptec.com> wrote:
> Signed-off-by: Luben Tuikov <luben_tuikov@adaptec.com>
<snip>
+static int sas_execute_task(struct sas_task *task, void *buffer, int size,
+ int pci_dma_dir)
<snip>
+ set_current_state(TASK_INTERRUPTIBLE);
+ schedule_timeout(HZ);
<snip>
+ set_current_state(TASK_INTERRUPTIBLE);
+ schedule_timeout(5*HZ);
Can you use msleep_interruptible() here? I don't see wait-queues in
the immediate vicinity. If not, and you're going for the normal -mm
route (and from there to mainline), can you use
schedule_timeout_interruptible(), please?
Thanks,
Nish
next prev parent reply other threads:[~2005-09-09 19:59 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-09 19:40 [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process (end devices) Luben Tuikov
2005-09-09 19:59 ` Nish Aravamudan [this message]
2005-09-09 20:11 ` Luben Tuikov
2005-09-09 23:25 ` James Bottomley
2005-09-10 2:44 ` Luben Tuikov
2005-09-10 5:39 ` Douglas Gilbert
2005-09-10 16:01 ` James Bottomley
2005-09-12 15:06 ` Luben Tuikov
2005-09-12 16:27 ` Patrick Mansfield
2005-09-12 20:08 ` Luben Tuikov
2005-09-13 9:05 ` Douglas Gilbert
2005-09-13 13:11 ` Luben Tuikov
2005-09-13 22:42 ` Patrick Mansfield
2005-09-14 12:28 ` Luben Tuikov
2005-09-14 17:13 ` Patrick Mansfield
2005-09-14 17:17 ` Luben Tuikov
2005-09-14 18:47 ` James Bottomley
2005-09-14 20:20 ` Luben Tuikov
2005-09-12 17:52 ` James Bottomley
2005-09-12 20:31 ` Luben Tuikov
2005-09-12 21:23 ` James Bottomley
2005-09-13 12:49 ` Luben Tuikov
2005-09-13 15:54 ` James Bottomley
2005-09-13 20:01 ` Luben Tuikov
2005-09-11 9:46 ` Christoph Hellwig
2005-09-12 6:17 ` Douglas Gilbert
2005-09-12 14:57 ` James Bottomley
2005-09-12 16:45 ` Patrick Mansfield
2005-09-12 17:21 ` James Bottomley
2005-09-12 18:46 ` Patrick Mansfield
2005-09-13 19:22 ` James Bottomley
2005-09-13 20:23 ` Luben Tuikov
2005-09-13 20:36 ` Matthew Wilcox
2005-09-13 21:02 ` Luben Tuikov
2005-09-13 21:37 ` Stefan Richter
2005-09-13 21:54 ` Luben Tuikov
2005-09-13 22:25 ` Patrick Mansfield
2005-09-14 5:22 ` Sergey Panov
2005-09-14 16:28 ` Patrick Mansfield
2005-09-14 12:13 ` Luben Tuikov
2005-09-14 4:57 ` Sergey Panov
2005-09-14 18:43 ` James Bottomley
2005-09-14 20:17 ` Luben Tuikov
2005-09-15 2:04 ` Sergey Panov
2005-09-12 20:20 ` Luben Tuikov
2005-09-12 20:09 ` Luben Tuikov
2005-09-12 19:39 ` Luben Tuikov
2005-09-12 18:17 ` Luben Tuikov
2005-09-13 10:25 ` Christoph Hellwig
2005-09-13 12:47 ` Douglas Gilbert
2005-09-13 14:58 ` Luben Tuikov
2005-09-12 22:39 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2005-09-12 19:04 James.Smart
2005-09-12 19:29 ` Patrick Mansfield
2005-09-12 19:53 James.Smart
2005-09-14 0:58 Ravi Anand
2005-09-14 17:46 Ravi Anand
2005-09-16 7:28 Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d05090912591d55be5f@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).