From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Maxey Subject: Re: isd200.c Has fatal bugs and is probably not used any more Date: Tue, 21 Aug 2007 15:24:21 -0500 Message-ID: <29728.1187727861@bebe.enoyolf.org> References: <46CB37B2.404@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bebe.enoyolf.org ([24.173.215.190]:39549 "EHLO bebe.enoyolf.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754206AbXHUUvz (ORCPT ); Tue, 21 Aug 2007 16:51:55 -0400 In-reply-to: <46CB37B2.404@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Boaz Harrosh Cc: =?ISO-8859-1?Q?Bj=F6rn_Stenberg?= , support@in-system.com, James Bottomley , Greg Kroah-Hartman , linux-scsi On Tue, 21 Aug 2007 22:06:26 +0300, Boaz Harrosh wrote: > Hi! > > the driver drivers/usb/storage/isd200.c has code like: > > static int isd200_action( struct us_data *us, int action, > void* pointer, int value ) > > ... > > case ACTION_READ_STATUS: > US_DEBUGP(" isd200_action(READ_STATUS)\n"); > ata.generic.ActionSelect = ACTION_SELECT_0|ACTION_SELECT_2; > ata.generic.RegisterSelect = > REG_CYLINDER_LOW | REG_CYLINDER_HIGH | > REG_STATUS | REG_ERROR; > srb->sc_data_direction = DMA_FROM_DEVICE; > srb->request_buffer = pointer; > srb->request_bufflen = value; > break; > ... > > Now what the hell is that hijacked scsi_cmnd and who said > that the srb->use_sg is Zero. If this is a regular queued > scsi_cmnd, this can easily crash. And at best a memory leak. > > The last git recorded real change to this driver was it's insertion > into git by Linus. > > Is this an indication that this driver is no longer used and > can be removed? All IBM bladecenters have the HW this driver supports. And it does mostly work. This particular frag requires USB_DEBUG enabled, correct?