Re: [PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 08/08/2024 08:10, Shawn Lin wrote:
> Hi Rob
> 
> 在 2024/8/8 13:29, Rob Herring (Arm) 写道:
>>
>> On Thu, 08 Aug 2024 11:52:42 +0800, Shawn Lin wrote:
>>> Document Rockchip UFS host controller for RK3576 SoC.
>>>
>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>
>>> ---
>>>
>>> Changes in v2:
>>> - renmae file name
>>> - fix all errors and pass the dt_binding_check:
>>>    make dt_binding_check DT_SCHEMA_FILES=rockchip,rk3576-ufs.yaml
>>>
>>>   .../bindings/ufs/rockchip,rk3576-ufs.yaml          | 96 ++++++++++++++++++++++
>>>   1 file changed, 96 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
>>   	 $id: http://devicetree.org/schemas/ufs/rockchip,ufs.yaml
>>   	file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml
> 
> This is already fixed by a resend v2 2/3 patch, a moment ago. Sorry for 
> that.

If you change patches, it is not a resend. Send a proper new version
with proper changelog.

> 
>> Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.example.dts:24:18: fatal error: dt-bindings/clock/rockchip,rk3576-cru.h: No such file or directory
>>     24 |         #include <dt-bindings/clock/rockchip,rk3576-cru.h>
>>        |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> compilation terminated.
> 
> There are still pending patches from Rockchip in queue for review. This
> patchset is based on them. I will wait for more comments and update them
> after all under-review patches got merged.

You need to document dependencies in changelog (---).

Best regards,
Krzysztof