From: Mike Christie <michael.christie@oracle.com>
To: Lee Duncan <lduncan@suse.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
mrangankar@marvell.com, njavali@marvell.com,
GR-QLogic-Storage-Upstream@marvell.com, cleech@redhat.com,
liuzhengyuang521@gmail.com
Subject: Re: [PATCH 3/6] scsi: iscsi: Remove iscsi_scan_finished.
Date: Mon, 28 Feb 2022 14:39:12 -0600 [thread overview]
Message-ID: <298112a4-d040-d855-e07b-558d2fc482d1@oracle.com> (raw)
In-Reply-To: <e77fae9c-d612-003f-5b9a-b0da4b389b14@suse.com>
On 2/28/22 12:05 PM, Lee Duncan wrote:
>> - if (shost->hostt->scan_finished) {
>> - if (scsi_queue_work(shost, &session->scan_work))
>> - atomic_inc(&ihost->nr_scans);
>> - }
>> ISCSI_DBG_TRANS_SESSION(session, "Completed unblocking session\n");
>> }
....
>
> I have no issue with this, but it seems kind of unrelated to speeding up session unblocking
It's related because in the next patch we stop creating the host's transport
wq which is used above in the chunk that was removed in __iscsi_unblock_session.
next prev parent reply other threads:[~2022-02-28 20:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 23:04 [PATCH 0/6] iscsi: Speed up failover with lots of devices Mike Christie
2022-02-26 23:04 ` [PATCH 1/6] scsi: iscsi: Fix recovery and ublocking race Mike Christie
2022-02-27 19:49 ` Lee Duncan
2022-02-28 20:06 ` Chris Leech
2022-02-26 23:04 ` [PATCH 2/6] scsi: iscsi: Speed up session unblocking and removal Mike Christie
2022-02-28 16:05 ` Lee Duncan
2022-02-28 20:06 ` Chris Leech
2022-02-26 23:04 ` [PATCH 3/6] scsi: iscsi: Remove iscsi_scan_finished Mike Christie
2022-02-28 18:05 ` Lee Duncan
2022-02-28 20:39 ` Mike Christie [this message]
2022-02-28 20:07 ` Chris Leech
2022-02-26 23:04 ` [PATCH 4/6] scsi: iscsi, ql4: Use per session workqueue for unbinding Mike Christie
2022-02-28 18:19 ` Lee Duncan
2022-02-28 20:07 ` Chris Leech
2022-02-26 23:04 ` [PATCH 5/6] scsi: iscsi: Use the session workqueue for recovery Mike Christie
2022-02-28 20:08 ` Chris Leech
2022-02-28 20:09 ` Lee Duncan
2022-02-26 23:04 ` [PATCH 6/6] scsi: iscsi: Drop temp workq_name Mike Christie
2022-02-28 20:08 ` Chris Leech
2022-02-28 22:49 ` Lee Duncan
2022-02-28 15:53 ` [PATCH 0/6] iscsi: Speed up failover with lots of devices Mike Christie
2022-03-02 4:20 ` Martin K. Petersen
2022-03-09 4:14 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=298112a4-d040-d855-e07b-558d2fc482d1@oracle.com \
--to=michael.christie@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=cleech@redhat.com \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=liuzhengyuang521@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=mrangankar@marvell.com \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox