From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E3FC41513 for ; Thu, 10 Aug 2023 16:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236609AbjHJQPm convert rfc822-to-8bit (ORCPT ); Thu, 10 Aug 2023 12:15:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236593AbjHJQPk (ORCPT ); Thu, 10 Aug 2023 12:15:40 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA07D211B; Thu, 10 Aug 2023 09:15:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 76729622F562; Thu, 10 Aug 2023 18:15:37 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id smA3OYxeUDzS; Thu, 10 Aug 2023 18:15:37 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 0F795622F56E; Thu, 10 Aug 2023 18:15:37 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5mrpLoPTvxi8; Thu, 10 Aug 2023 18:15:36 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id D925E622F562; Thu, 10 Aug 2023 18:15:36 +0200 (CEST) Date: Thu, 10 Aug 2023 18:15:36 +0200 (CEST) From: Richard Weinberger To: Christoph Hellwig Cc: linux-mtd , Stephan Wurm , stable , Miquel Raynal , Vignesh Raghavendra , Oliver Neukum , Ali Akcaagac , Jamie Lenehan , James Bottomley , "Martin K. Petersen" , Ezequiel Garcia , linux-kernel , linux-scsi Message-ID: <298860961.5257332.1691684136772.JavaMail.zimbra@nod.at> In-Reply-To: References: <20230810160019.16977-1-richard@nod.at> <20230810160019.16977-2-richard@nod.at> Subject: Re: [PATCH 1/7] ubi: block: Refactor sg list processing for highmem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: block: Refactor sg list processing for highmem Thread-Index: 8dyYm2xXARBKErxuajcdul9nN/entQ== Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Christoph Hellwig" >> Refactor ubi_eba_read_leb_sg() to use kmap_atomic() for sg list >> access. >> Since kmap_atomic() disables preempt a bounce buffer is needed. >> kmap_local_page() is not used to allow easy backporting of this patch >> to older kernels. >> >> The followup patches in this series will switch to kmap_sg() >> and we can remove our own helper and the bounce buffer. > > Please just use kmap_local and avoid the bounce buffering. Patch 6 does this. Thanks, //richard