From: "Peter Wang (王信友)" <peter.wang@mediatek.com>
To: "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
"manivannan.sadhasivam@linaro.org"
<manivannan.sadhasivam@linaro.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"quic_nguyenb@quicinc.com" <quic_nguyenb@quicinc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"daejun7.park@samsung.com" <daejun7.park@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>
Subject: Re: [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions
Date: Wed, 15 Jan 2025 11:05:00 +0000 [thread overview]
Message-ID: <2a90f92e4c72b7c11f3e44d885aaf69d16eed3f9.camel@mediatek.com> (raw)
In-Reply-To: <69992b3e3e3434a5c7643be5a64de48be892ca46.1736793068.git.quic_nguyenb@quicinc.com>
On Mon, 2025-01-13 at 10:32 -0800, Bao D. Nguyen wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> According to the UFS Device Specification, the
> dExtendedUFSFeaturesSupport
> defines the support for TOO_HIGH_TEMPERATURE as bit[4] and the
> TOO_LOW_TEMPERATURE as bit[5]. Correct the code to match with
> the UFS device specification definition.
>
> Fixes: e88e2d322 ("scsi: ufs: core: Probe for temperature
> notification support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@quicinc.com>
> Reviewed-by: Avri Altman <Avri.Altman@wdc.com>
> ---
> include/ufs/ufs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h
> index e594abe..f0c6111 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -386,8 +386,8 @@ enum {
>
> /* Possible values for dExtendedUFSFeaturesSupport */
> enum {
> - UFS_DEV_LOW_TEMP_NOTIF = BIT(4),
> - UFS_DEV_HIGH_TEMP_NOTIF = BIT(5),
> + UFS_DEV_HIGH_TEMP_NOTIF = BIT(4),
> + UFS_DEV_LOW_TEMP_NOTIF = BIT(5),
> UFS_DEV_EXT_TEMP_NOTIF = BIT(6),
> UFS_DEV_HPB_SUPPORT = BIT(7),
> UFS_DEV_WRITE_BOOSTER_SUP = BIT(8),
> --
> 2.7.4
>
Hi Bao,
Thanks for fix this bug.
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
next prev parent reply other threads:[~2025-01-15 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 18:32 [PATCH v2 1/1] scsi: ufs: core: Fix the HIGH/LOW_TEMP Bit Definitions Bao D. Nguyen
2025-01-15 11:05 ` Peter Wang (王信友) [this message]
2025-01-17 16:59 ` Manivannan Sadhasivam
2025-01-21 17:18 ` Martin K. Petersen
2025-02-04 3:35 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a90f92e4c72b7c11f3e44d885aaf69d16eed3f9.camel@mediatek.com \
--to=peter.wang@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox