From: Oliver Neukum <oneukum@suse.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: John Youn <John.Youn@synopsys.com>,
Felipe Balbi <balbi@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 01/36] target: Handle MI_REPORT_SUPPORTED_OPERATION_CODES
Date: Thu, 7 Jul 2022 10:01:05 +0200 [thread overview]
Message-ID: <2ab8a2af-a3f0-c67d-13db-a8b4efe797be@suse.com> (raw)
In-Reply-To: <118900ffaf094a279f7799ac9d2c73265c889121.1657149962.git.Thinh.Nguyen@synopsys.com>
On 07.07.22 01:34, Thinh Nguyen wrote:
> Microsoft Windows checks for MI_REPORT_SUPPORTED_OPERATION_CODES. Let's
> handle this MAINTENANCE_IN command and report supported commands.
> +sense_reason_t
> +target_emulate_report_supported_opcodes(struct se_cmd *cmd)
> +{
> + unsigned char *cdb = cmd->t_task_cdb;
> + unsigned char *buf;
> + u8 supported = 0;
> +
[..]
> + case ATA_12:
> + case ATA_16:
> + case VERIFY:
> + case ZBC_IN:
> + case ZBC_OUT:
> + default:
> + break;
Why the NOP here?
If you want to document something, a comment
would be nice.
Regards
Oliver
next prev parent reply other threads:[~2022-07-07 8:01 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 23:34 [PATCH 00/36] usb: gadget: f_tcm: Enhance UASP driver Thinh Nguyen
2022-07-06 23:34 ` [PATCH 01/36] target: Handle MI_REPORT_SUPPORTED_OPERATION_CODES Thinh Nguyen
2022-07-07 8:01 ` Oliver Neukum [this message]
2022-07-07 11:44 ` kernel test robot
2022-07-06 23:34 ` [PATCH 02/36] target: Add overlapped response to tmrsp_table Thinh Nguyen
2022-07-06 23:34 ` [PATCH 03/36] target: Don't drain empty list Thinh Nguyen
2022-07-07 12:42 ` Dmitry Bogdanov
2022-07-06 23:34 ` [PATCH 04/36] target: Does tmr notify on aborted command Thinh Nguyen
2022-07-07 12:56 ` Dmitry Bogdanov
2022-07-08 23:11 ` Thinh Nguyen
2022-07-11 9:44 ` Dmitry Bogdanov
2022-07-12 2:57 ` Thinh Nguyen
2022-07-11 10:31 ` Bodo Stroesser
2022-07-12 3:09 ` Thinh Nguyen
2022-07-06 23:34 ` [PATCH 05/36] target: Don't remove command too early Thinh Nguyen
2022-07-07 13:16 ` Dmitry Bogdanov
2022-07-08 23:40 ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 06/36] target: Return Function Complete Thinh Nguyen
2022-07-07 13:34 ` Dmitry Bogdanov
2022-07-08 23:51 ` Thinh Nguyen
2022-07-11 9:53 ` Dmitry Bogdanov
2022-07-06 23:35 ` [PATCH 07/36] target: Don't do tmr_notify on empty aborted list Thinh Nguyen
2022-07-07 13:36 ` Dmitry Bogdanov
2022-07-08 23:53 ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 08/36] target: Refactor core_tmr_abort_task Thinh Nguyen
2022-07-07 13:40 ` Dmitry Bogdanov
2022-07-09 0:02 ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 09/36] target: Add common Task Management values Thinh Nguyen
2022-07-07 19:36 ` Dmitry Bogdanov
2022-07-09 0:04 ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 10/36] target: Implement TMR_ABORT_TASK_SET Thinh Nguyen
2022-07-07 19:40 ` Dmitry Bogdanov
2022-07-08 9:50 ` Dmitry Bogdanov
2022-07-09 0:46 ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 11/36] target: Properly set Sense Data Length of CHECK CONDITION Thinh Nguyen
2022-07-07 8:24 ` Oliver Neukum
2022-07-07 10:21 ` Thinh Nguyen
2022-07-07 20:27 ` Dmitry Bogdanov
2022-07-09 0:11 ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 12/36] target: Properly set Sense data length when copy sense Thinh Nguyen
2022-07-07 20:53 ` Dmitry Bogdanov
2022-07-09 0:11 ` Thinh Nguyen
2022-07-06 23:35 ` [PATCH 13/36] target: Don't respond TMR_LUN_DOES_NOT_EXIST for all TMR failure Thinh Nguyen
2022-07-06 23:35 ` [PATCH 14/36] target: Introduce target_submit_tmr_fail_response Thinh Nguyen
2022-07-06 23:35 ` [PATCH 15/36] target: Include INQUIRY length Thinh Nguyen
2022-07-07 10:11 ` Konstantin Shelekhin
2022-07-14 1:42 ` Thinh Nguyen
2022-07-06 23:36 ` [PATCH 16/36] usb: gadget: f_tcm: Increase stream count Thinh Nguyen
2022-07-06 23:36 ` [PATCH 17/36] usb: gadget: f_tcm: Increase bMaxBurst Thinh Nguyen
2022-07-06 23:36 ` [PATCH 18/36] usb: gadget: f_tcm: Don't set static stream_id Thinh Nguyen
2022-07-08 7:00 ` Dmitry Bogdanov
2022-07-09 0:12 ` Thinh Nguyen
2022-07-06 23:36 ` [PATCH 19/36] usb: gadget: f_tcm: Allocate matching number of commands to streams Thinh Nguyen
2022-07-06 23:36 ` [PATCH 20/36] usb: gadget: f_tcm: Limit number of sessions Thinh Nguyen
2022-07-07 6:57 ` Greg Kroah-Hartman
2022-07-07 10:31 ` Thinh Nguyen
2022-07-06 23:36 ` [PATCH 21/36] usb: gadget: f_tcm: Handle multiple commands in parallel Thinh Nguyen
2022-07-06 23:36 ` [PATCH 22/36] usb: gadget: f_tcm: Use extra number of commands Thinh Nguyen
2022-07-06 23:36 ` [PATCH 23/36] usb: gadget: f_tcm: Return ATA cmd direction Thinh Nguyen
2022-07-06 23:36 ` [PATCH 24/36] usb: gadget: f_tcm: Execute command on write completion Thinh Nguyen
2022-07-06 23:36 ` [PATCH 25/36] usb: gadget: f_tcm: Minor cleanup redundant code Thinh Nguyen
2022-07-06 23:37 ` [PATCH 26/36] usb: gadget: f_tcm: Don't free command immediately Thinh Nguyen
2022-07-06 23:37 ` [PATCH 27/36] usb: gadget: f_tcm: Translate error to sense Thinh Nguyen
2022-07-06 23:37 ` [PATCH 28/36] usb: gadget: f_tcm: Cleanup unused variable Thinh Nguyen
2022-07-06 23:37 ` [PATCH 29/36] usb: gadget: f_tcm: Update state on data write Thinh Nguyen
2022-07-06 23:37 ` [PATCH 30/36] usb: gadget: f_tcm: Handle abort command Thinh Nguyen
2022-07-06 23:37 ` [PATCH 31/36] usb: gadget: f_tcm: Cleanup requests on ep disable Thinh Nguyen
2022-07-06 23:37 ` [PATCH 32/36] usb: gadget: f_tcm: Send sense reason Thinh Nguyen
2022-07-08 7:35 ` Dmitry Bogdanov
2022-07-09 0:13 ` Thinh Nguyen
2022-07-06 23:37 ` [PATCH 33/36] usb: gadget: f_tcm: Save CPU ID per command Thinh Nguyen
2022-07-06 23:37 ` [PATCH 34/36] usb: gadget: f_tcm: Free tags earlier Thinh Nguyen
2022-07-07 9:14 ` Dmitriy Bogdanov
2022-07-07 10:11 ` Thinh Nguyen
2022-07-07 12:37 ` Dmitry Bogdanov
2022-07-06 23:38 ` [PATCH 35/36] usb: gadget: f_tcm: Handle TASK_MANAGEMENT commands Thinh Nguyen
2022-07-08 9:07 ` Dmitry Bogdanov
2022-07-09 0:41 ` Thinh Nguyen
2022-07-06 23:38 ` [PATCH 36/36] usb: gadget: f_tcm: Comply with UAS Task Management requirement Thinh Nguyen
2022-07-07 4:38 ` [PATCH 00/36] usb: gadget: f_tcm: Enhance UASP driver Christoph Hellwig
2022-07-07 4:50 ` Thinh Nguyen
2022-07-07 6:59 ` Greg Kroah-Hartman
2022-07-07 10:15 ` Thinh Nguyen
2022-07-07 11:15 ` Greg Kroah-Hartman
[not found] <202207120920.oEIle78M-lkp@intel.com>
2022-07-12 2:48 ` [PATCH 01/36] target: Handle MI_REPORT_SUPPORTED_OPERATION_CODES kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab8a2af-a3f0-c67d-13db-a8b4efe797be@suse.com \
--to=oneukum@suse.com \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox