Re: [PATCH 07/36] target: Don't do tmr_notify on empty aborted list

Dmitry Bogdanov
2022-07-07T13:36:55Z

Hi Thinh,

On Wed, Jul 06, 2022 at 04:35:07PM -0700, Thinh Nguyen wrote:
> If there's no command to abort, just skip doing tmr_notify to an empty
> list.
AFAIK, that was intentionaly:
https://lore.kernel.org/all/20200726153510.13077-3-bstroesser@ts.fujitsu.com/
'If no commands were aborted, an empty list is supplied.'

> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> ---
> drivers/target/target_core_tmr.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c
> index 724ddabda488..718d985e4860 100644
> --- a/drivers/target/target_core_tmr.c
> +++ b/drivers/target/target_core_tmr.c
> @@ -167,9 +167,6 @@ void core_tmr_abort_task(
> spin_unlock_irqrestore(&dev->queues[i].lock, flags);
> }
>
> - if (dev->transport->tmr_notify)
> - dev->transport->tmr_notify(dev, TMR_ABORT_TASK, &aborted_list);
> -
> printk("ABORT_TASK: Sending TMR_FUNCTION_COMPLETE for ref_tag: %lld\n",
> tmr->ref_task_tag);
> tmr->response = TMR_FUNCTION_COMPLETE;