Re: [PATCH 01/36] target: Handle MI_REPORT_SUPPORTED_OPERATION_CODES

Oliver Neukum
2022-07-07T08:01:14Z

On 07.07.22 01:34, Thinh Nguyen wrote:
> Microsoft Windows checks for MI_REPORT_SUPPORTED_OPERATION_CODES. Let's
> handle this MAINTENANCE_IN command and report supported commands.

> +sense_reason_t
> +target_emulate_report_supported_opcodes(struct se_cmd *cmd)
> +{
> + unsigned char *cdb = cmd->t_task_cdb;
> + unsigned char *buf;
> + u8 supported = 0;
> +
[..]
> + case ATA_12:
> + case ATA_16:
> + case VERIFY:
> + case ZBC_IN:
> + case ZBC_OUT:
> + default:
> + break;

Why the NOP here?
If you want to document something, a comment
would be nice.

Regards
Oliver