public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: merez@codeaurora.org
Cc: james.bottomley@hansenpartnership.com,
	linux-scsi@vger.kernel.org, santoshsy@gmail.com, arnd@linaro.org,
	venkat@linaro.org, subhashj@codeaurora.org,
	sthumma@codeaurora.org, merez@codeaurora.org,
	Vinayak Holikatti <vinholikatti@gmail.com>
Subject: Re: [PATCH V6 Resend2 2/2] [SCSI] ufs: Correct the expected data transfersize
Date: Tue, 30 Apr 2013 13:39:34 -0700	[thread overview]
Message-ID: <2b37ba8d8fb30c725313c73c8d8db6cd.squirrel@www.codeaurora.org> (raw)
In-Reply-To: <1361882086-2548-2-git-send-email-vinholikatti@gmail.com>

Hi James,

Can this patch be poushed to 3.9+ merge window?

Thnaks,
Maya
> This patch corrects the expected data transfer size of the
> command UPIU. The current implementation of cmd->transfersize
> is wrong as it probably equal to sector size. With this
> implementation the transfer size is updated correctly
>
> Reported-by: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
> Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
> Tested-by: Maya Erez <merez@codeaurora.org>
> Signed-off-by: Santosh Yaraganavi <santoshsy@gmail.com>
> Signed-off-by: Vinayak Holikatti <vinholikatti@gmail.com>
> ---
>  drivers/scsi/ufs/ufshcd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 60fd40c..c32a478 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -478,7 +478,7 @@ static void ufshcd_compose_upiu(struct ufshcd_lrb
> *lrbp)
>  		ucd_cmd_ptr->header.dword_2 = 0;
>
>  		ucd_cmd_ptr->exp_data_transfer_len =
> -			cpu_to_be32(lrbp->cmd->transfersize);
> +			cpu_to_be32(lrbp->cmd->sdb.length);
>
>  		memcpy(ucd_cmd_ptr->cdb,
>  		       lrbp->cmd->cmnd,
> --
> 1.7.5.4
>
>


-- 
Maya Erez
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation


  reply	other threads:[~2013-04-30 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-26 12:34 [PATCH V6 Resend2 1/2] [SCSI] ufs: Add Platform glue driver for ufshcd Vinayak Holikatti
2013-02-26 12:34 ` [PATCH V6 Resend2 2/2] [SCSI] ufs: Correct the expected data transfersize Vinayak Holikatti
2013-04-30 20:39   ` merez [this message]
2013-04-30 20:39 ` [PATCH V6 Resend2 1/2] [SCSI] ufs: Add Platform glue driver for ufshcd merez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b37ba8d8fb30c725313c73c8d8db6cd.squirrel@www.codeaurora.org \
    --to=merez@codeaurora.org \
    --cc=arnd@linaro.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=santoshsy@gmail.com \
    --cc=sthumma@codeaurora.org \
    --cc=subhashj@codeaurora.org \
    --cc=venkat@linaro.org \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox