From: James Smart <jsmart2021@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
James Smart <james.smart@broadcom.com>
Cc: Ram Vegesna <ram.vegesna@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Daniel Wagner <dwagner@suse.de>, Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp()
Date: Sat, 19 Jun 2021 08:44:01 -0700 [thread overview]
Message-ID: <2bd91d5f-5dac-bbaf-361a-7594c1e84f6f@gmail.com> (raw)
In-Reply-To: <YMyi4LNaVmD7kQEN@mwanda>
On 6/18/2021 6:42 AM, Dan Carpenter wrote:
> The "rc" variable needs to be signed for the error handling to work.
> It holds either a negative error code, EFC_SCSI_CALL_COMPLETE (0),
> or EFC_SCSI_CALL_ASYNC (1).
>
> Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/elx/libefc/efc_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks!
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
prev parent reply other threads:[~2021-06-19 15:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 13:42 [PATCH] scsi: elx: libefc: signedness bug in efc_d_send_prli_rsp() Dan Carpenter
2021-06-19 15:44 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd91d5f-5dac-bbaf-361a-7594c1e84f6f@gmail.com \
--to=jsmart2021@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dwagner@suse.de \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ram.vegesna@broadcom.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox