From: Matthew Wilcox <matthew.r.wilcox@intel.com>
To: linux-scsi@vger.kernel.org
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>, willy@linux.intel.com
Subject: [PATCH 2/7] mpt3sas: Remove use of DEF_SCSI_QCMD
Date: Thu, 27 Mar 2014 16:40:31 -0400 [thread overview]
Message-ID: <2ce8dda9284f463216f4c527d32fee497f9da3ac.1395952569.git.matthew.r.wilcox@intel.com> (raw)
In-Reply-To: <cover.1395952569.git.matthew.r.wilcox@intel.com>
In-Reply-To: <cover.1395952569.git.matthew.r.wilcox@intel.com>
Removing the host_lock from the I/O submission path gives a huge
scalability improvement.
Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 952f6e0..18e713d 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -3515,7 +3515,7 @@ _scsih_eedp_error_handling(struct scsi_cmnd *scmd, u16 ioc_status)
/**
- * _scsih_qcmd_lck - main scsi request entry point
+ * _scsih_qcmd - main scsi request entry point
* @scmd: pointer to scsi command object
* @done: function pointer to be invoked on completion
*
@@ -3526,9 +3526,9 @@ _scsih_eedp_error_handling(struct scsi_cmnd *scmd, u16 ioc_status)
* SCSI_MLQUEUE_HOST_BUSY if the entire host queue is full
*/
static int
-_scsih_qcmd_lck(struct scsi_cmnd *scmd, void (*done)(struct scsi_cmnd *))
+_scsih_qcmd(struct Scsi_Host *shost, struct scsi_cmnd *scmd)
{
- struct MPT3SAS_ADAPTER *ioc = shost_priv(scmd->device->host);
+ struct MPT3SAS_ADAPTER *ioc = shost_priv(shost);
struct MPT3SAS_DEVICE *sas_device_priv_data;
struct MPT3SAS_TARGET *sas_target_priv_data;
Mpi2SCSIIORequest_t *mpi_request;
@@ -3541,7 +3541,6 @@ _scsih_qcmd_lck(struct scsi_cmnd *scmd, void (*done)(struct scsi_cmnd *))
scsi_print_command(scmd);
#endif
- scmd->scsi_done = done;
sas_device_priv_data = scmd->device->hostdata;
if (!sas_device_priv_data || !sas_device_priv_data->sas_target) {
scmd->result = DID_NO_CONNECT << 16;
@@ -3656,8 +3655,6 @@ _scsih_qcmd_lck(struct scsi_cmnd *scmd, void (*done)(struct scsi_cmnd *))
out:
return SCSI_MLQUEUE_HOST_BUSY;
}
-static DEF_SCSI_QCMD(_scsih_qcmd)
-
/**
* _scsih_normalize_sense - normalize descriptor and fixed format sense data
--
1.9.0
next prev parent reply other threads:[~2014-03-27 20:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 20:40 [PATCH 0/7] Performance improvements for LSI SCSI cards Matthew Wilcox
2014-03-27 20:40 ` [PATCH 1/7] mpt3sas: Remove uses of serial_number Matthew Wilcox
2014-04-02 10:39 ` Christoph Hellwig
2014-03-27 20:40 ` Matthew Wilcox [this message]
2014-04-02 10:41 ` [PATCH 2/7] mpt3sas: Remove use of DEF_SCSI_QCMD Christoph Hellwig
2014-04-02 13:20 ` Matthew Wilcox
2014-03-27 20:40 ` [PATCH 3/7] mpt2sas: Remove uses of serial_number Matthew Wilcox
2014-04-02 10:41 ` Christoph Hellwig
2014-03-27 20:40 ` [PATCH 4/7] mpt2sas: Remove use of DEF_SCSI_QCMD Matthew Wilcox
2014-03-27 20:40 ` [PATCH 5/7] mpt2sas: Add free smids to the head, not tail of list Matthew Wilcox
2014-04-02 10:41 ` Christoph Hellwig
2014-03-27 20:40 ` [PATCH 6/7] fusion: Add free msg frames " Matthew Wilcox
2014-04-02 10:42 ` Christoph Hellwig
2014-03-27 20:40 ` [PATCH 7/7] fusion: Remove use of DEF_SCSI_QCMD Matthew Wilcox
2014-03-31 5:54 ` [PATCH 0/7] Performance improvements for LSI SCSI cards Nicholas A. Bellinger
2014-04-02 8:06 ` Desai, Kashyap
2014-04-02 22:28 ` Krishnamoorthy, Praveen
2014-04-07 11:51 ` Reddy, Sreekanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce8dda9284f463216f4c527d32fee497f9da3ac.1395952569.git.matthew.r.wilcox@intel.com \
--to=matthew.r.wilcox@intel.com \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).